Fix issues related to Python 3 compatibility#2125
Merged
rachel-fenichel merged 3 commits intoRaspberryPiFoundation:developfrom Nov 19, 2018
Merged
Fix issues related to Python 3 compatibility#2125rachel-fenichel merged 3 commits intoRaspberryPiFoundation:developfrom
rachel-fenichel merged 3 commits intoRaspberryPiFoundation:developfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Contributor
Author
|
Commenting for CLA check |
…/blockly into python3_further_upgrade
Contributor
Author
|
Commenting for CLA check |
Contributor
Author
|
Signed CLA with commit account as well, should hopefully work now |
|
CLAs look good, thanks! |
rachel-fenichel
approved these changes
Nov 19, 2018
Merged
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Jun 7, 2019
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Jun 11, 2019
tansly
added a commit
to tansly/scratch-blocks
that referenced
this pull request
Jul 12, 2019
delasare
pushed a commit
to scratchfoundation/scratch-blocks
that referenced
this pull request
Oct 25, 2023
Port of RaspberryPiFoundation/blockly#2123 (by @gomercin) Fix issues related to Python 3 compatibility Port of RaspberryPiFoundation/blockly#2125 (by @gomercin) Fix compatibility problems with Python 3's reduce(), filter() et al. Fix Python 3 compatibility problems related to str encodings Remove obsolete UnicodeEncodeError handling
delasare
pushed a commit
to scratchfoundation/scratch-blocks
that referenced
this pull request
Oct 25, 2023
Port of RaspberryPiFoundation/blockly#2123 (by @gomercin) Fix issues related to Python 3 compatibility Port of RaspberryPiFoundation/blockly#2125 (by @gomercin) Fix compatibility problems with Python 3's reduce(), filter() et al. Fix Python 3 compatibility problems related to str encodings Remove obsolete UnicodeEncodeError handling
DBDev-IT
pushed a commit
to DashBlocks/scratch-blocks
that referenced
this pull request
Sep 2, 2025
Port of RaspberryPiFoundation/blockly#2123 (by @gomercin) Fix issues related to Python 3 compatibility Port of RaspberryPiFoundation/blockly#2125 (by @gomercin) Fix compatibility problems with Python 3's reduce(), filter() et al. Fix Python 3 compatibility problems related to str encodings Remove obsolete UnicodeEncodeError handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Most changes are for except usages and paranthesis around print.
decode had to be added for Python 3.4 compatibility, in build.py#341, because of changes in return type of response.read() and supported argument types for json.loads between 2.7, 3.4 and 3.6
Resolves
Further updates following up #2112
Proposed Changes
Reason for Changes
Making remaining python files compatible with Python 2 and 3 versions.
This patch also covers Python 3.4 compatibility for build.py
Test Coverage
All files are inspected by PyCharm
build.py and dedup_json.py is tested on Ubuntu 16.04 by comparing generated files using:
json_to_js and create_messages are indirectly used by build.
xliff_to_json.py is not tested but changes are not important to affect the code flow.
Additional Information
tests.py does not seem to be testing an existing function, so it might need to be removed or updated.
Using "." for relative imports are encouraged (like "from .common import InputError" ) but it makes scripts trickier to run so they are not changed.