Skip to content

[rendering] update build script#2113

Merged
rachel-fenichel merged 2 commits intoRaspberryPiFoundation:renderingfrom
samelhusseini:rendering_build
Nov 15, 2018
Merged

[rendering] update build script#2113
rachel-fenichel merged 2 commits intoRaspberryPiFoundation:renderingfrom
samelhusseini:rendering_build

Conversation

@samelhusseini
Copy link
Contributor

@samelhusseini samelhusseini commented Nov 14, 2018

Updated build script to support 'core' and 'scratch' rendering.
Blocks are shared, 'core' will exclude the scratch rendering file and 'scratch' will exclude the core renderer (block_render_svg).

'core' generates blockly_compressed.js
'scratch' generates blockly_scratch_compressed.js

Thoughts on what we want to call this? Can probably re-visit that later.
I also added a scratch_playground which is a dupe of playground.html but references the blockly_scratch_compressed.js

Note: calling this script currently will fail as block_render_svg_scratch.js doesn't exist yet.
I've left accessible as is.

@rachel-fenichel
Copy link
Collaborator

Let's use 2018_rendering as the temporary name, instead of scratch. So blockly_2018_rendering_compressed.js, 2018_rendering as the flag, etc. We can revisit it to pick a proper name, but this can help us avoid some confusion in the interim.

The additional playground is fine. Eventually we'll make that an option on the main playground.

@samelhusseini
Copy link
Contributor Author

Updated:
build.py 2018_rendering
Playground: 2018_rendering_playground.html
Render SVG file: block_render_svg_2018_rendering.js
Output: blockly_2018_rendering_(un)compressed.js

@rachel-fenichel rachel-fenichel merged commit ec661b5 into RaspberryPiFoundation:rendering Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants