Skip to content

Conversation

@rachel-fenichel
Copy link
Collaborator

@rachel-fenichel rachel-fenichel commented Apr 2, 2025

Fixes #357

Fixes #359

  • Patches isDragging in mover.ts

Tested by:

  • Doing keyboard drags that end in an Esc
  • Doing keyboard drags that end in an Enter
  • Doing mouse drags after the fact to confirm that mouse dragging still works

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner April 2, 2025 01:21
@rachel-fenichel rachel-fenichel requested review from gonfunko and removed request for a team April 2, 2025 01:21
@rachel-fenichel rachel-fenichel merged commit 5428df4 into RaspberryPiFoundation:main Apr 2, 2025
4 checks passed
@rachel-fenichel rachel-fenichel deleted the movers branch April 2, 2025 16:24
* The stashed isDragging function, which is replaced at the beginning
* of a keyboard drag and reset at the end of a keyboard drag.
*/
oldIsDragging: (() => boolean) | null = null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been per-workspace (and patching/unpatching handled carefully) because Mover can handle multiple simultaneous moves on one or more workspaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monkeypatch WorkspaceSvg.isDragging to return true if a keyboard "drag" is in progress Consolidate Mover classes

3 participants