chore: move paste implementation into clipboard.ts #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Mar 6, 2025
cpcallen
reviewed
Mar 6, 2025
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
The second commit closes the event group in the case where paste succeeds; this was previously omitted, which was a bug.
There is only one commit in this PR!
Collaborator
Author
|
Oops! Added the second commit. |
gonfunko
pushed a commit
that referenced
this pull request
Mar 14, 2025
* chore: move paste implementation into clipboard.ts * fix: correctly set event group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling of #281
Moves the actual implementation of paste out of
navigation.tsand intoclipboard.tsalong with the rest of the callback. It's only used in one place and there was not a good reason to have the callback split into two pieces like this.The second commit closes the event group in the case where paste succeeds; this was previously omitted, which was a bug.
Tested by copying and pasting in various places and checking that behaviour is consistent with main.