chore: move workspace movement into a separate file #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
approved these changes
Mar 6, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Another nice cleanup, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't know exactly what free movement on the workspace will look like yet, but we know we'll want some form of it.
This PR consolidates the existing code into a single action file, including implementation code that used to be in
navigation.ts. As a side benefit, you can see from the result that there's no dependency on theNavigationclass at this point: all of workspace navigation can be done by interacting directly with the workspace and its cursor.Tested by modifying
Navigation.setCursorOnWorkspaceFocusto force the cursor to go to the workspace, then using the relevant keyboard shortcuts.This is pure cleanup with no behaviour changes.