Merge pull request #8648 from RasaHQ/8587-yaml-reader-sentryfix

Check for missing intent value in stories and rules and raise exception

changelog/8587.misc.md

@@ -0,0 +1 @@
+Catch `AttributeError` when reading stories or rules in YAML format and raise warning when intent value is missing in stories or rules.

data/test_yaml_stories/rules_missing_intent.yml

@@ -0,0 +1,7 @@
+version: "2.0"
+
+rules:
+  - rule: greet user
+    steps:
+    - intent:
+    - action: utter_greet

data/test_yaml_stories/stories_missing_intent.yml

@@ -0,0 +1,7 @@
+version: "2.0"
+
+stories:
+  - story: greet user
+    steps:
+    - intent:
+    - action: utter_greet

rasa/shared/core/training_data/story_reader/yaml_story_reader.py

@@ -362,7 +362,15 @@ def _parse_or_statement(self, step: Dict[Text, Any]) -> None:
     def _user_intent_from_step(
         self, step: Dict[Text, Any]
     ) -> Tuple[Text, Optional[Text]]:
-        user_intent = step.get(KEY_USER_INTENT, "").strip()
+        try:
+            user_intent = step.get(KEY_USER_INTENT, "").strip()
+        except AttributeError:
+            rasa.shared.utils.io.raise_warning(
+                f"Issue found in '{self.source_name}':\n"
+                f"Missing intent value in {self._get_item_title()} step: {step} .",
+                docs=self._get_docs_link(),
+            )
+            user_intent = ""
 
         if not user_intent and KEY_USER_MESSAGE not in step:
             rasa.shared.utils.io.raise_warning(

tests/shared/core/training_data/story_reader/test_yaml_story_reader.py

@@ -611,3 +611,19 @@ def test_read_from_file_skip_validation(monkeypatch: MonkeyPatch):
         _ = reader.read_from_file(yaml_file, skip_validation=False)
 
     assert reader.read_from_file(yaml_file, skip_validation=True) == []
+
+
+@pytest.mark.parametrize(
+    "file",
+    [
+        "data/test_yaml_stories/rules_missing_intent.yml",
+        "data/test_yaml_stories/stories_missing_intent.yml",
+    ],
+)
+def test_raises_exception_missing_intent_in_rules(file: Text, domain: Domain):
+    reader = YAMLStoryReader(domain)
+
+    with pytest.warns(UserWarning) as warning:
+        reader.read_from_file(file)
+
+    assert "Missing intent value" in warning[0].message.args[0]