Merge pull request #8684 from RasaHQ/8590-required-slots

Handle empty slot mappings in domain forms

changelog/8590.bugfix.md

@@ -0,0 +1 @@
+Handle `AttributeError ` thrown by empty slot mappings in domain form through refactoring.

rasa/shared/core/domain.py

@@ -1860,7 +1860,11 @@ def slot_mapping_for_form(self, form_name: Text) -> Dict[Text, Any]:
         Returns:
             The slot mapping or an empty dictionary in case no mapping was found.
         """
-        return self.forms.get(form_name, {})[REQUIRED_SLOTS_KEY]
+        form = self.forms.get(form_name)
+        if form:
+            return form[REQUIRED_SLOTS_KEY]
+
+        return {}
 
 
 class SlotMapping(Enum):

tests/shared/core/test_domain.py

@@ -1424,3 +1424,26 @@ def test_domain_count_conditional_response_variations():
     )
     count_conditional_responses = domain.count_conditional_response_variations()
     assert count_conditional_responses == 5
+
+
+def test_domain_with_no_form_slots():
+    domain = Domain.from_yaml(
+        """
+        version: "2.0"
+        forms:
+          contract_form:
+        """
+    )
+    assert domain.slot_mapping_for_form("contract_form") == {}
+
+
+def test_domain_with_empty_required_slots():
+    with pytest.raises(InvalidDomain):
+        Domain.from_yaml(
+            """
+            version: "2.0"
+            forms:
+              contract_form:
+                required_slots:
+            """
+        )