Test VR Validated condition #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
requested review from
ELENAGER,
ShyamsundarR,
raghavendra-talur and
BenamarMk
3 tasks
nirs
force-pushed
the
vr-validated-test
branch
from
03ab552 to
283a6ad
Compare
ELENAGER
approved these changes
Sep 30, 2024
nirs
force-pushed
the
vr-validated-test
branch
from
283a6ad to
5735835
Compare
This helper fail with this error:
"failed to wait for volRep condition type to change to 'ConditionCompleted' (%d)"
But the actual check was:
len(updatedVolRep.Status.Conditions) == 3
and no condition status was checked. This causes 24 tests to fail when
adding the new Validated condition to match csi-addons 0.10.0 conditions.
Now we check that the Completed condition is true and log a more
sensible error message.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Split to: - waitForVolRepCondition() - accept condition name and status. With this we can wait until VR is Completed=true, or Validated=false. - waitForProtectedPVC() - wait until the related protected pvc is successful. Used only for positive tests. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Add the new VR Validate condition to all tests, and allow testing
negative flows like VR that failed validation or missing Validated
condition.
New promoteOptions{} allows simulation of 2 issues:
- Validated failed: The VR will never complete, blocking deletion of the
VR and VRG. With this fix deletion will succeed.
- Validated condition missing - running ramen 4.17 on system with older
csi-addons that does not report the condition. In this case ramen
continue normally, and deletion of the VR and VRG will be blocked.
We can extend this later to support more options.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
This simulates the bug when user select the wrong dr policy without flattening enabled when protecting for a PVC that needs flattening. Without the fix this test will timeout when deleting the VRG. With the fix the VRG should be deleted. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
In csi-addons < 0.10.0 we could not detect failed validation since the Validated condition is missing. Add 2 tests: - VR failed validation: the VRG should block deletion until the VR is deleted manually. - VR completed: the VRG should not block deletion because the Validated condition is missing. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
force-pushed
the
vr-validated-test
branch
from
5735835 to
1f247fc
Compare
BenamarMk
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the vrg test infrastructure so we can test negative flows when VR has failed validation does not complete.
Add new tests for:
Based on #1570, required to pass the new tests.