Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ATmega32U2, ATmega16U2, ATmega3208, and ATmega3209 #164

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

zacharytomlinson
Copy link
Contributor

Added deps for 32u2 target, fixed accidental import of 16u2 target when targeting atmega64 and added note to readme to check downloaded atdf file names as the capitalization is sometimes wonky.

@zacharytomlinson
Copy link
Contributor Author

zacharytomlinson commented Oct 17, 2024

NOTES:

  • I added a note in the readme to check downloaded atdf file names as they are capitalized oddly in both sources.
  • Do we still need the impl for Peripherals in the devices/mod.rs? The change log for the atmega64 updates has that in
    there but no other chip implementations have those anymore (including the up-to-date atmega64 definition). If not we can remove those and reference a different pull request in the readme so others aren't under the impression that is still needed.

@zacharytomlinson zacharytomlinson marked this pull request as ready for review October 17, 2024 04:13
@zacharytomlinson
Copy link
Contributor Author

Is there anything else you need me to do here @Rahix?

@Rahix Rahix changed the title Added 32u2 and fixed 16u2 bug Add support for ATmega32U2, ATmega16U2, ATmega3208, and ATmega3209 Jan 4, 2025
@Rahix Rahix changed the title Add support for ATmega32U2, ATmega16U2, ATmega3208, and ATmega3209 Add ATmega32U2, ATmega16U2, ATmega3208, and ATmega3209 Jan 4, 2025
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I've taken the liberty to clean up your commits such that each commit contains a logical change. In the future, please don't put so many things into a single PR, instead send multiple PRs — one for each chip, for example.

The overall changes themselves look fine, thanks a lot for your contribution!

@Rahix Rahix merged commit a23bdab into Rahix:main Jan 4, 2025
2 checks passed
@zacharytomlinson
Copy link
Contributor Author

Sounds good, and will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants