refactor southbound templates api #374

lanchongyizu · 2016-11-16T07:26:51Z

@RackHD/corecommitters @panpan0000 @iceiilin @keedya @johren

houndci-bot · 2016-11-16T07:26:58Z

spec/lib/task-spec.js

                    expect(task.options.fileServer).to.equal(fileServerUri);
                    expect(task.options.baseRoute).to.equal(server + '/api/current');
-                    expect(task.options.templatesRoute).to.equal(server + '/api/current/templates');
+                    expect(task.options.templatesRoute).to.equal(server + '/api/current/nodes/testtarget/templates');


Line is too long.

houndci-bot · 2016-11-16T07:26:58Z

lib/task.js

        self.renderContext.api.lookups = self.renderContext.api.base + '/lookups';
        self.renderContext.api.files = self.renderContext.api.base + '/files';
        self.renderContext.api.nodes = self.renderContext.api.base + '/nodes';
+        self.renderContext.api.templates = self.renderContext.api.nodes + '/' + self.nodeId + '/templates';


Line is too long.

panpan0000 · 2016-11-17T09:41:38Z

:+0: , sounds functional good.

houndci-bot · 2016-11-17T09:52:08Z

spec/lib/task-data/schemas/linux-command-schema-ut-helper.js

 var positiveSetParamCommand = {
    'commands[1]': 'touch foo.txt', //allow duplicated command
-    'commands[1].downloadUrl': ['/foo', '/foo123/123/bar'],
+    'commands[1].downloadUrl': ['http://abc.com/foo', 'http://10.0.0.1:8080/foo123/123/bar', 'www.abc.com/abc'],


Line is too long.

JenkinsRHD · 2016-11-17T10:19:06Z

BUILD on-tasks #1751 : UNSTABLE

** BUILD build-config-setup #160638: SUCCESS
** BUILD unit-tests #10112: SUCCESS
** BUILD smoke-test #3799: UNSTABLE
** BUILD on-taskgraph #1721: SUCCESS
- ** BUILD build-config-setup #160639: SUCCESS
- ** BUILD unit-tests #10113: SUCCESS
** BUILD on-http #2847: SUCCESS
- ** BUILD build-config-setup #160640: SUCCESS
- ** BUILD unit-tests #10114: SUCCESS

BUILD smoke-test #3799 Error Logs ▼

Test Name: test_list_simple_storage
Error Details: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '742', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2e6-R1p0eb9wQS2jPLEGXhEJyA"', 'Date': 'Thu, 17 Nov 2016 10:17:33 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"error":{"code":"Base.1.0.GeneralError","message":"A general error has occurred. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"@odata.type":"#Message.1.0.0.Message","MessageId":"Base.1.0.Messages.InvalidObject","Description":"Indicates that the object in question is invalid according to the implementation. Examples include a firmware update malformed URI.","Message":"The object at %1 is invalid.","Resolution":"Either the object is malformed or the URI is not correct. Correct the condition and resubmit the request if it failed.","Severity":"Critical"},{"MessageId":"RackHD.1.0.DetailedErrorMessage","Message":"No Catalogs Found for Source (smart).","Description":"Contains the detailed error message contents"}]}}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-tasks/RackHD/test/tests/api/redfish_1_0/systems_tests.py", line 110, in test_list_simple_storage
redfish().list_simple_storage(dataId)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/apis/redfishv_api.py", line 4047, in list_simple_storage
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '742', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2e6-R1p0eb9wQS2jPLEGXhEJyA"', 'Date': 'Thu, 17 Nov 2016 10:17:33 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"error":{"code":"Base.1.0.GeneralError","message":"A general error has occurred. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"@odata.type":"#Message.1.0.0.Message","MessageId":"Base.1.0.Messages.InvalidObject","Description":"Indicates that the object in question is invalid according to the implementation. Examples include a firmware update malformed URI.","Message":"The object at %1 is invalid.","Resolution":"Either the object is malformed or the URI is not correct. Correct the condition and resubmit the request if it failed.","Severity":"Critical"},{"MessageId":"RackHD.1.0.DetailedErrorMessage","Message":"No Catalogs Found for Source (smart).","Description":"Contains the detailed error message contents"}]}}

Test Name: test_catalogs
Error Details: Catalog smart not found in node 582d829ee8e8a47f098372ef!
Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-tasks/RackHD/test/tests/api/v2_0/catalogs_tests.py", line 48, in test_catalogs
fail('Catalog {0} not found in node {1}!'.format(source,node.get('id')))
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 220, in fail
raise ASSERTION_ERROR(message)
AssertionError: Catalog smart not found in node 582d829ee8e8a47f098372ef!

houndci-bot · 2016-11-21T09:46:37Z

spec/lib/utils/job-utils/command-util-spec.js

            });
            expect(builtCommands[2]).to.deep.equal({
-                cmd: 'runSomething', downloadUrl: 'api/downloadScript'
+                cmd: 'runSomething', downloadUrl: 'http://10.0.0.1:8080/api/downloadScript?nodeId={{context.target}}'


Line is too long.

houndci-bot · 2016-11-21T09:46:37Z

spec/lib/utils/job-utils/command-util-spec.js

                },
                {
-                    command: 'runSomething', downloadUrl: 'api/downloadScript'
+                    command: 'runSomething', downloadUrl: 'http://10.0.0.1:8080/api/downloadScript?nodeId={{context.target}}'


Line is too long.

houndci-bot · 2016-11-21T09:46:38Z

lib/task-data/tasks/install-esx.js

        rackhdCallbackScript: 'esx.rackhdcallback',
        esxBootConfigTemplate: 'esx-boot-cfg',
-        esxBootConfigTemplateUri: '{{api.templates}}/{{options.esxBootConfigTemplate}}',
+        esxBootConfigTemplateUri: '{{api.templates}}/{{options.esxBootConfigTemplate}}?nodeId={{context.target}}',


Line is too long.

houndci-bot · 2016-11-21T09:46:38Z

lib/jobs/secure-erase-drive.js


        // add script's url in the first command
-        this.commands[0].downloadUrl = '/api/current/templates/secure_erase.py';
+        this.commands[0].downloadUrl = '{{api.templates}}/secure_erase.py?nodeId={{context.target}}';


Line is too long.

JenkinsRHD · 2016-11-21T10:12:04Z

BUILD on-tasks #1754 : UNSTABLE

** BUILD build-config-setup #163024: SUCCESS
** BUILD unit-tests #10138: SUCCESS
** BUILD smoke-test #3816: UNSTABLE
** BUILD on-taskgraph #1726: SUCCESS
- ** BUILD build-config-setup #163025: SUCCESS
- ** BUILD unit-tests #10139: SUCCESS
** BUILD on-http #2860: SUCCESS
- ** BUILD build-config-setup #163026: SUCCESS
- ** BUILD unit-tests #10140: SUCCESS

BUILD smoke-test #3816 Error Logs ▼

Test Name: test_list_simple_storage Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '742', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2e6-R1p0eb9wQS2jPLEGXhEJyA"', 'Date': 'Mon, 21 Nov 2016 10:09:59 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"error":{"code":"Base.1.0.GeneralError","message":"A general error has occurred. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"@odata.type":"#Message.1.0.0.Message","MessageId":"Base.1.0.Messages.InvalidObject","Description":"Indicates that the object in question is invalid according to the implementation. Examples include a firmware update malformed URI.","Message":"The object at %1 is invalid.","Resolution":"Either the object is malformed or the URI is not correct. Correct the condition and resubmit the request if it failed.","Severity":"Critical"},{"MessageId":"RackHD.1.0.DetailedErrorMessage","Message":"No Catalogs Found for Source (smart).","Description":"Contains the detailed error message contents"}]}}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-tasks/RackHD/test/tests/api/redfish_1_0/systems_tests.py", line 110, in test_list_simple_storage
redfish().list_simple_storage(dataId)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/apis/redfishv_api.py", line 4047, in list_simple_storage
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '742', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2e6-R1p0eb9wQS2jPLEGXhEJyA"', 'Date': 'Mon, 21 Nov 2016 10:09:59 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"error":{"code":"Base.1.0.GeneralError","message":"A general error has occurred. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"@odata.type":"#Message.1.0.0.Message","MessageId":"Base.1.0.Messages.InvalidObject","Description":"Indicates that the object in question is invalid according to the implementation. Examples include a firmware update malformed URI.","Message":"The object at %1 is invalid.","Resolution":"Either the object is malformed or the URI is not correct. Correct the condition and resubmit the request if it failed.","Severity":"Critical"},{"MessageId":"RackHD.1.0.DetailedErrorMessage","Message":"No Catalogs Found for Source (smart).","Description":"Contains the detailed error message contents"}]}}

Test Name: test_catalogs
Error Details: Catalog smart not found in node 5832c6d419d4735809e15ca8!
Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-tasks/RackHD/test/tests/api/v2_0/catalogs_tests.py", line 48, in test_catalogs
fail('Catalog {0} not found in node {1}!'.format(source,node.get('id')))
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 220, in fail
raise ASSERTION_ERROR(message)
AssertionError: Catalog smart not found in node 5832c6d419d4735809e15ca8!

brianparry

👍

brianparry · 2016-11-22T15:32:38Z

@lanchongyizu I think it would be best to have @anhou or @yyscamper work with you to merge this to make sure all the dependencies are covered.

anhou · 2016-11-22T20:40:06Z

@lanchongyizu if this PR had dependency with PR RackHD/on-http#531, at least the depenency PR test should pass.
and if it's possible to run regression test locally or in a separated branch, it's better

yyscamper · 2016-11-23T16:50:32Z

@lanchongyizu: Forgot to mention you, this description should be changed since now the downloadUrl is full path not relative path:

on-tasks/lib/task-data/schemas/linux-command.json

Line 44 in 4cfd6a6

    
           "description": "Specify the download URL (relative to RackHD southbound API server) if the command needs to download some data or script from RackHD before execution",

cgx027 · 2016-11-24T01:56:34Z

lib/task-data/schemas/linux-command.json

                    "description": "Specify the download URL (relative to RackHD southbound API server) if the command needs to download some data or script from RackHD before execution",
                    "type": "string",
-                    "pattern": "^/[a-zA-Z0-9+-.#?=\\\/]+"
+                    "minLength": 1


I would suggest to keep the pattern and check downloadurl against a valid http URL pattern. There are talks/PRs around changing relative URI to fullpath URL and this check will help people catch errors if a legacy relative URI is used.

Ref: https://github.com/RackHD/RackHD/issues/489#issuecomment-262570418

cgx027 · 2016-11-24T02:01:53Z

lib/task-data/tasks/catalog-driveid.js

            {
                command: 'sudo node get_driveid.js',
-                downloadUrl: '/api/current/templates/get_driveid.js'
+                downloadUrl: '{{api.templates}}/get_driveid.js?nodeId={{context.target}}'


A picky style suggestion. It's more like we leave spaces around(before and after) the render elements, like following example. In this PR, there are no spaces between api.templates and the surrounding {{ }}.

You can decide yourself on whether to change it or not.

lib/graphs/discovery-sku-graph.js 14: nodeIds: [ "{{ options.nodeId }}" ]

Please check with https://github.com/RackHD/on-tasks/blob/master/lib/task-data/tasks/install-centos.js#L14.
Thanks.

cgx027 · 2016-11-24T02:07:30Z

lib/task-data/tasks/catalog-smart.js

            {
                command: 'sudo bash get_smart.sh',
-                downloadUrl: '/api/current/templates/get_smart.sh'
+                downloadUrl: '{{api.templates}}/get_smart.sh?nodeId={{context.target}}'


This suggestion has gone beyond this PR, but {{ context.target }} gives people unclear hint that is actually referring to a node ID. something like ?nodeId={{context.nodeId}}' or ?nodeId={{ tasks.nodeID}}' would make the code more readable and less error-prong.

Agreed? @yyscamper @anhou . If yes, this would generate a follow up refactor task.

Just find the refactor has already been done in master, so please update {{context.target}} to {{nodeId}}
Ref: https://github.com/RackHD/on-http/blob/master/lib/services/swagger-api-service.js#L346

This doesn't work for task rendering, but only for templates and profiles rendering.
Thanks.

cgx027

+0, I would suggest to add a schema pattern check against downloadUrl.

houndci-bot · 2016-11-24T09:53:19Z

spec/lib/task-data/schemas/linux-command-schema-ut-helper.js

 var positiveSetParamCommand = {
    'commands[1]': 'touch foo.txt', //allow duplicated command
-    'commands[1].downloadUrl': ['/foo', '/foo123/123/bar'],
+    'commands[1].downloadUrl': ['http://abc.com/foo', 'http://10.0.0.1:8080/foo123/123/bar?nodeId={{context.target}}', 'www.abc.com/abc'],


Line is too long.

JenkinsRHD · 2016-11-24T09:58:29Z

BUILD on-tasks #1756 : FAILURE

** BUILD build-config-setup #166411: SUCCESS
** BUILD unit-tests #10159: SUCCESS
** BUILD on-taskgraph #1730: SUCCESS
- ** BUILD build-config-setup #166413: SUCCESS
- ** BUILD unit-tests #10161: SUCCESS
** BUILD on-http #2872: FAILURE

houndci-bot · 2016-11-27T13:30:19Z

lib/task-data/tasks/rm-bmc-credentials.js

            {
                command: 'sudo ./remove_bmc_credentials.sh',
-                downloadUrl: '/api/current/templates/remove_bmc_credentials.sh'
+                downloadUrl: '{{ api.templates }}/remove_bmc_credentials.sh?nodeId={{ task.nodeId }}'


Line is too long.

houndci-bot · 2016-11-27T13:30:19Z

lib/task-data/tasks/install-ubuntu.js

        profile: 'install-ubuntu.ipxe',
        installScript: 'ubuntu-preseed',
-        installScriptUri: '{{api.templates}}/{{options.installScript}}',
+        installScriptUri: '{{ api.templates }}/{{ options.installScript }}?nodeId={{ task.nodeId }}',


Line is too long.

houndci-bot · 2016-11-27T13:30:19Z

lib/task-data/tasks/install-suse.js

        profile: 'install-suse.ipxe',
        installScript: 'suse-autoinst.xml',
-        installScriptUri: '{{api.templates}}/{{options.installScript}}',
+        installScriptUri: '{{ api.templates }}/{{ options.installScript }}?nodeId={{ task.nodeId }}',


Line is too long.

houndci-bot · 2016-11-27T13:30:19Z

lib/task-data/tasks/install-photon-os.js

        profile: 'install-photon-os.ipxe',
        installScript: 'photon-os-ks',
-        installScriptUri: '{{api.templates}}/{{options.installScript}}',
+        installScriptUri: '{{ api.templates }}/{{ options.installScript }}?nodeId={{ task.nodeId }}',


Line is too long.

houndci-bot · 2016-11-27T13:30:20Z

lib/task-data/tasks/install-esx.js

        profile: 'install-esx.ipxe',
        installScript: 'esx-ks',
-        installScriptUri: '{{api.templates}}/{{options.installScript}}',
+        installScriptUri: '{{ api.templates }}/{{ options.installScript }}?nodeId={{ task.nodeId }}',


Line is too long.

houndci-bot · 2016-11-27T13:30:20Z

lib/task-data/tasks/install-coreos.js

        profile: 'install-coreos.ipxe',
        installScript: 'install-coreos.sh',
-        installScriptUri: '{{api.templates}}/{{options.installScript}}',
+        installScriptUri: '{{ api.templates }}/{{ options.installScript }}?nodeId={{ task.nodeId }}',


Line is too long.

houndci-bot · 2016-11-27T13:30:20Z

lib/task-data/tasks/install-centos.js

        profile: 'install-centos.ipxe',
        installScript: 'centos-ks',
-        installScriptUri: '{{api.templates}}/{{options.installScript}}',
+        installScriptUri: '{{ api.templates }}/{{ options.installScript }}?nodeId={{ task.nodeId }}',


Line is too long.

JenkinsRHD · 2016-11-27T14:03:17Z

BUILD on-tasks #1760 : UNSTABLE

** BUILD build-config-setup #169985: SUCCESS
** BUILD unit-tests #10187: SUCCESS
** BUILD smoke-test #3843: UNSTABLE
** BUILD on-taskgraph #1736: UNSTABLE
- ** BUILD build-config-setup #169987: SUCCESS
- ** BUILD unit-tests #10188: UNSTABLE
** BUILD on-http #2882: SUCCESS
- ** BUILD build-config-setup #169990: SUCCESS
- ** BUILD unit-tests #10189: SUCCESS

BUILD smoke-test #3843 Error Logs ▼

Test Name: test_list_simple_storage Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '742', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2e6-R1p0eb9wQS2jPLEGXhEJyA"', 'Date': 'Sun, 27 Nov 2016 14:01:27 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"error":{"code":"Base.1.0.GeneralError","message":"A general error has occurred. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"@odata.type":"#Message.1.0.0.Message","MessageId":"Base.1.0.Messages.InvalidObject","Description":"Indicates that the object in question is invalid according to the implementation. Examples include a firmware update malformed URI.","Message":"The object at %1 is invalid.","Resolution":"Either the object is malformed or the URI is not correct. Correct the condition and resubmit the request if it failed.","Severity":"Critical"},{"MessageId":"RackHD.1.0.DetailedErrorMessage","Message":"No Catalogs Found for Source (smart).","Description":"Contains the detailed error message contents"}]}}

Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-tasks/RackHD/test/tests/api/redfish_1_0/systems_tests.py", line 110, in test_list_simple_storage
redfish().list_simple_storage(dataId)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/apis/redfishv_api.py", line 4047, in list_simple_storage
callback=params.get('callback'))
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 342, in request
headers=headers)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 184, in GET
query_params=query_params)
File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '742', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"2e6-R1p0eb9wQS2jPLEGXhEJyA"', 'Date': 'Sun, 27 Nov 2016 14:01:27 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"error":{"code":"Base.1.0.GeneralError","message":"A general error has occurred. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"@odata.type":"#Message.1.0.0.Message","MessageId":"Base.1.0.Messages.InvalidObject","Description":"Indicates that the object in question is invalid according to the implementation. Examples include a firmware update malformed URI.","Message":"The object at %1 is invalid.","Resolution":"Either the object is malformed or the URI is not correct. Correct the condition and resubmit the request if it failed.","Severity":"Critical"},{"MessageId":"RackHD.1.0.DetailedErrorMessage","Message":"No Catalogs Found for Source (smart).","Description":"Contains the detailed error message contents"}]}}

Test Name: test_catalogs
Error Details: Catalog smart not found in node 583ae617f709f31909e42799!
Stack Trace: Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
self._testFunc()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
compatability.capture_type_error(s_func)
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
func()
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
func(test_case.state.get_state())
File "/home/jenkins/workspace/on-tasks/RackHD/test/tests/api/v2_0/catalogs_tests.py", line 48, in test_catalogs
fail('Catalog {0} not found in node {1}!'.format(source,node.get('id')))
File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 220, in fail
raise ASSERTION_ERROR(message)
AssertionError: Catalog smart not found in node 583ae617f709f31909e42799!

BUILD unit-tests #10188 Error Logs ▼

Test Name: Graph Library should validate all existing graphs not requiring user input for null values Error Details: Value does not exist for task.nodeId Stack Trace: TemplateRenderError: Value does not exist for task.nodeId at Task.renderString (node_modules/on-tasks/lib/task.js:214:19) at node_modules/on-tasks/lib/task.js:262:37 at arrayMap (node_modules/lodash/index.js:1406:25) at Function.map (node_modules/lodash/index.js:6710:14) at Task.render (node_modules/on-tasks/lib/task.js:254:18) at Task.renderOptions (node_modules/on-tasks/lib/task.js:273:25) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at node_modules/lodash/index.js:3073:15 at baseForOwn (node_modules/lodash/index.js:2046:14) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at arrayEach (node_modules/lodash/index.js:1289:13) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at node_modules/lodash/index.js:3073:15 at baseForOwn (node_modules/lodash/index.js:2046:14) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at Task.renderOwnOptions (node_modules/on-tasks/lib/task.js:282:29) at node_modules/on-tasks/lib/task.js:180:22 at Object.finallyHandler (node_modules/on-core/node_modules/bluebird/js/main/finally.js:39:23) at Object.tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23) at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31) at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18) at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12) at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10) at Immediate.Async.drainQueues [as _onImmediate] (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

BUILD on-taskgraph #1736 Error Logs ▼

Test Name: Graph Library should validate all existing graphs not requiring user input for null values Error Details: Value does not exist for task.nodeId Stack Trace: TemplateRenderError: Value does not exist for task.nodeId at Task.renderString (node_modules/on-tasks/lib/task.js:214:19) at node_modules/on-tasks/lib/task.js:262:37 at arrayMap (node_modules/lodash/index.js:1406:25) at Function.map (node_modules/lodash/index.js:6710:14) at Task.render (node_modules/on-tasks/lib/task.js:254:18) at Task.renderOptions (node_modules/on-tasks/lib/task.js:273:25) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at node_modules/lodash/index.js:3073:15 at baseForOwn (node_modules/lodash/index.js:2046:14) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at arrayEach (node_modules/lodash/index.js:1289:13) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at node_modules/lodash/index.js:3073:15 at baseForOwn (node_modules/lodash/index.js:2046:14) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at Task.renderOwnOptions (node_modules/on-tasks/lib/task.js:282:29) at node_modules/on-tasks/lib/task.js:180:22 at Object.finallyHandler (node_modules/on-core/node_modules/bluebird/js/main/finally.js:39:23) at Object.tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23) at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31) at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18) at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12) at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10) at Immediate.Async.drainQueues [as _onImmediate] (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

houndci-bot reviewed Nov 16, 2016

View reviewed changes

lanchongyizu mentioned this pull request Nov 16, 2016

refactor southbound templates api RackHD/on-http#531

Merged

lanchongyizu force-pushed the refactor-southbound-template-api branch from f9034fc to 6aa98af Compare November 17, 2016 09:51

houndci-bot reviewed Nov 17, 2016

View reviewed changes

This was referenced Nov 18, 2016

make option downloadUrl to use FULL PATH RackHD/on-skupack#57

Merged

make option downloadUrl to use FULL PATH RackHD/on-taskgraph#187

Merged

lanchongyizu force-pushed the refactor-southbound-template-api branch from 6aa98af to 73dfa97 Compare November 21, 2016 09:46

houndci-bot reviewed Nov 21, 2016

View reviewed changes

brianparry approved these changes Nov 22, 2016

View reviewed changes

yyscamper approved these changes Nov 22, 2016

View reviewed changes

cgx027 reviewed Nov 24, 2016

View reviewed changes

lanchongyizu force-pushed the refactor-southbound-template-api branch from 73dfa97 to 37123fb Compare November 24, 2016 09:53

houndci-bot reviewed Nov 24, 2016

View reviewed changes

refactor /templates/:name to /templates/:name?nodeId=:nodeId

f03c597

lanchongyizu force-pushed the refactor-southbound-template-api branch from 37123fb to f03c597 Compare November 27, 2016 13:30

houndci-bot reviewed Nov 27, 2016

View reviewed changes

cgx027 approved these changes Nov 29, 2016

View reviewed changes

anhou merged commit 209c51b into RackHD:master Nov 30, 2016

refactor southbound templates api #374

refactor southbound templates api #374

Uh oh!

Conversation

lanchongyizu commented Nov 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panpan0000 commented Nov 17, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JenkinsRHD commented Nov 17, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JenkinsRHD commented Nov 21, 2016

Uh oh!

brianparry left a comment

Choose a reason for hiding this comment

Uh oh!

brianparry commented Nov 22, 2016

Uh oh!

anhou commented Nov 22, 2016

Uh oh!

yyscamper commented Nov 23, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgx027 Nov 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgx027 Nov 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgx027 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JenkinsRHD commented Nov 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JenkinsRHD commented Nov 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

lanchongyizu commented Nov 16, 2016 •

edited

Loading

cgx027 Nov 24, 2016 •

edited

Loading

cgx027 Nov 25, 2016 •

edited

Loading