make option downloadUrl to use FULL PATH #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhou
approved these changes
Nov 23, 2016
lanchongyizu
force-pushed
the
refactor-southbound-template-api
branch
from
50d47c2 to
6ebf775
Compare
houndci-bot
reviewed
Nov 24, 2016
| "commands": [ | ||
| { | ||
| "downloadUrl": "/api/1.1/templates/cisco-catalog-version.py", | ||
| "downloadUrl": "{{api.templates}}/cisco-catalog-version.py?nodeId={{context.target}}", |
houndci-bot
reviewed
Nov 24, 2016
| "commands": [ | ||
| { | ||
| "downloadUrl": "/api/1.1/templates/brocade-catalog-version.py", | ||
| "downloadUrl": "{{api.templates}}/brocade-catalog-version.py?nodeId={{context.target}}", |
houndci-bot
reviewed
Nov 24, 2016
| "commands": [ | ||
| { | ||
| "downloadUrl": "/api/1.1/templates/arista-catalog-version.py", | ||
| "downloadUrl": "{{api.templates}}/arista-catalog-version.py?nodeId={{context.target}}", |
Contributor
|
Looks good to me. |
lanchongyizu
force-pushed
the
refactor-southbound-template-api
branch
from
6ebf775 to
d644dc1
Compare
Contributor
|
BUILD on-taskgraph #1735 : UNSTABLE
BUILD unit-tests #10186 Error Logs ▼Test Name: Graph Library should validate all existing graphs not requiring user input for null values Error Details: Value does not exist for task.nodeId Stack Trace: TemplateRenderError: Value does not exist for task.nodeId at Task.renderString (node_modules/on-tasks/lib/task.js:214:19) at node_modules/on-tasks/lib/task.js:262:37 at arrayMap (node_modules/lodash/index.js:1406:25) at Function.map (node_modules/lodash/index.js:6710:14) at Task.render (node_modules/on-tasks/lib/task.js:254:18) at Task.renderOptions (node_modules/on-tasks/lib/task.js:273:25) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at node_modules/lodash/index.js:3073:15 at baseForOwn (node_modules/lodash/index.js:2046:14) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at arrayEach (node_modules/lodash/index.js:1289:13) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at node_modules/on-tasks/lib/task.js:276:31 at node_modules/lodash/index.js:10033:16 at node_modules/lodash/index.js:3073:15 at baseForOwn (node_modules/lodash/index.js:2046:14) at Function.transform (node_modules/lodash/index.js:10032:39) at Task.renderOptions (node_modules/on-tasks/lib/task.js:275:22) at Task.renderOwnOptions (node_modules/on-tasks/lib/task.js:282:29) at node_modules/on-tasks/lib/task.js:180:22 at Object.finallyHandler (node_modules/on-core/node_modules/bluebird/js/main/finally.js:39:23) at Object.tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23) at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31) at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18) at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12) at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10) at Immediate.Async.drainQueues [as _onImmediate] (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)BUILD smoke-test #3842 Error Logs ▼Test Name: redfish_emc_compose_test Error Details: Failure running Graph.Emc.Compose.System -------------------- >> begin captured logging << -------------------- tests.api.v1_1.workflows_tests: INFO: Starting AMQP listener for node 583ae385e93bf11609015603 amqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US'] amqp: DEBUG: Open OK! urllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', BadStatusLine("''",))': /api/1.1/nodes/583ae385e93bf11609015603/workflows/active kombu: INFO: Starting AMQP worker -> graph.finished.*> amqp: DEBUG: Start from server, version: 0.9, properties: {u'information': u'Licensed under the MPL. See http://www.rabbitmq.com/', u'product': u'RabbitMQ', u'copyright': u'Copyright (C) 2007-2013 GoPivotal, Inc.', u'capabilities': {u'exchange_exchange_bindings': True, u'connection.blocked': True, u'authentication_failure_close': True, u'basic.nack': True, u'consumer_priorities': True, u'consumer_cancel_notify': True, u'publisher_confirms': True}, u'platform': u'Erlang/OTP', u'version': u'3.2.4'}, mechanisms: [u'AMQPLAIN', u'PLAIN'], locales: [u'en_US'] amqp: DEBUG: Open OK! kombu.mixins: INFO: Connected to amqp://guest:**@127.0.0.1:9091// amqp: DEBUG: using channel_id: 1 amqp: DEBUG: Channel open kombu: INFO: Stopping AMQP worker -> graph.finished.*> tests.api.v1_1.workflows_tests: ERROR: { "active_task": { "3e9afc11-61b7-45eb-831f-6ee3aa9dd3ad": { "error": "Error: EndPoint Resource(s) Already Allocated: ComputeElement0,StorageElement3 at /home/vagrant/src/on-taskgraph/node_modules/on-tasks/lib/jobs/emc-compose-system.js:244:23 at tryCatcher (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23) at Promise._settlePromiseFromHandler (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31) at Promise._settlePromiseAt (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18) at Async._drainQueue (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12) at Async._drainQueues (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10) at Immediate.Async.drainQueues [as _onImmediate] (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14) at processImmediate [as _immediateCallback] (timers.js:383:17)", "friendlyName": "EMC Compose System", "ignoreFailure": false, "implementsTask": "Task.Base.Emc.Compose.System", "injectableName": "Task.Emc.Compose.System", "instanceId": "3e9afc11-61b7-45eb-831f-6ee3aa9dd3ad", "label": "emc-compose-system", "name": "Task.Emc.Compose.System", "options": { "_taskTimeout": 86400000, "action": "compose", "endpoints": [ "ComputeElement0", "StorageElement1", "StorageElement3" ], "name": "newSystem" }, "properties": {}, "runJob": "Job.Emc.Compose.System", "state": "failed", "taskEndTime": "2016-11-27T13:46:12.185Z", "taskStartTime": "2016-11-27T13:46:12.017Z", "terminalOnStates": [ "timeout", "cancelled", "failed" ], "waitingOn": {} }, "e8f0b6dd-f3e6-4214-8b9b-48fb8f12bcb9": { "friendlyName": "Create Default Pollers", "ignoreFailure": false, "implementsTask": "Task.Base.Pollers.Redfish.CreateDefault", "injectableName": "Task.Inline.Pollers.Redfish.CreateDefault", "instanceId": "e8f0b6dd-f3e6-4214-8b9b-48fb8f12bcb9", "label": "create-redfish-pollers", "name": "Task.Inline.Pollers.Redfish.CreateDefault", "options": { "_taskTimeout": 86400000, "pollers": [ { "config": { "command": "systems.logservices" }, "pollInterval": 10000, "type": "redfish" } ] }, "properties": {}, "runJob": "Job.Pollers.CreateDefault", "state": "failed", "taskEndTime": "2016-11-27T13:46:12.185Z", "terminalOnStates": [ "succeeded", "timeout", "cancelled", "failed" ], "waitingOn": { "3e9afc11-61b7-45eb-831f-6ee3aa9dd3ad": "succeeded" } } }, "graph_name": "Graph.Emc.Compose.System", "route_id": "bb27e173-0cf3-40d3-bf0b-91b347224331", "status": "failed", "target": "583ae385e93bf11609015603" } amqp: DEBUG: Closed channel #1 modules.worker: INFO: stopping subtask for 583ae385e93bf11609015603 --------------------- >> end captured logging << --------------------- Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/on-taskgraph/RackHD/test/tests/api/v1_1/redfish_endpoint_tests.py", line 262, in redfish_emc_compose_test self.__post_node_workflow([id], 'Graph.Emc.Compose.System', body) File "/home/jenkins/workspace/on-taskgraph/RackHD/test/tests/api/v1_1/redfish_endpoint_tests.py", line 92, in __post_node_workflow workflow.post_workflows(graph_name, nodes=nodes, tasks=tasks, data=body, callback=callback) File "/home/jenkins/workspace/on-taskgraph/RackHD/test/tests/api/v1_1/workflows_tests.py", line 174, in post_workflows self.run_workflow_tasks(self.__tasks, timeout_sec) File "/home/jenkins/workspace/on-taskgraph/RackHD/test/tests/api/v1_1/workflows_tests.py", line 205, in run_workflow_tasks fail('Failure running {0}'.format(self.__graph_name)) File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 220, in fail raise ASSERTION_ERROR(message) 'Failure running Graph.Emc.Compose.System\n-------------------- >> begin captured logging << --------------------\ntests.api.v1_1.workflows_tests: INFO: Starting AMQP listener for node 583ae385e93bf11609015603\namqp: DEBUG: Start from server, version: 0.9, properties: {u\'information\': u\'Licensed under the MPL. See http://www.rabbitmq.com/\', u\'product\': u\'RabbitMQ\', u\'copyright\': u\'Copyright (C) 2007-2013 GoPivotal, Inc.\', u\'capabilities\': {u\'exchange_exchange_bindings\': True, u\'connection.blocked\': True, u\'authentication_failure_close\': True, u\'basic.nack\': True, u\'consumer_priorities\': True, u\'consumer_cancel_notify\': True, u\'publisher_confirms\': True}, u\'platform\': u\'Erlang/OTP\', u\'version\': u\'3.2.4\'}, mechanisms: [u\'AMQPLAIN\', u\'PLAIN\'], locales: [u\'en_US\']\namqp: DEBUG: Open OK!\nurllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by \'ProtocolError(\'Connection aborted.\', BadStatusLine("\'\'",))\': /api/1.1/nodes/583ae385e93bf11609015603/workflows/active\nkombu: INFO: Starting AMQP worker -> graph.finished.*>\namqp: DEBUG: Start from server, version: 0.9, properties: {u\'information\': u\'Licensed under the MPL. See http://www.rabbitmq.com/\', u\'product\': u\'RabbitMQ\', u\'copyright\': u\'Copyright (C) 2007-2013 GoPivotal, Inc.\', u\'capabilities\': {u\'exchange_exchange_bindings\': True, u\'connection.blocked\': True, u\'authentication_failure_close\': True, u\'basic.nack\': True, u\'consumer_priorities\': True, u\'consumer_cancel_notify\': True, u\'publisher_confirms\': True}, u\'platform\': u\'Erlang/OTP\', u\'version\': u\'3.2.4\'}, mechanisms: [u\'AMQPLAIN\', u\'PLAIN\'], locales: [u\'en_US\']\namqp: DEBUG: Open OK!\nkombu.mixins: INFO: Connected to amqp://guest:**@127.0.0.1:9091//\namqp: DEBUG: using channel_id: 1\namqp: DEBUG: Channel open\nkombu: INFO: Stopping AMQP worker -> graph.finished.*>\ntests.api.v1_1.workflows_tests: ERROR: {\n "active_task": {\n "3e9afc11-61b7-45eb-831f-6ee3aa9dd3ad": {\n "error": "Error: EndPoint Resource(s) Already Allocated: ComputeElement0,StorageElement3\n at /home/vagrant/src/on-taskgraph/node_modules/on-tasks/lib/jobs/emc-compose-system.js:244:23\n at tryCatcher (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)\n at Promise._settlePromiseFromHandler (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31)\n at Promise._settlePromiseAt (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18)\n at Async._drainQueue (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)\n at Async._drainQueues (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)\n at Immediate.Async.drainQueues [as _onImmediate] (/home/vagrant/src/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)\n at processImmediate [as _immediateCallback] (timers.js:383:17)",\n "friendlyName": "EMC Compose System",\n "ignoreFailure": false,\n "implementsTask": "Task.Base.Emc.Compose.System",\n "injectableName": "Task.Emc.Compose.System",\n "instanceId": "3e9afc11-61b7-45eb-831f-6ee3aa9dd3ad",\n "label": "emc-compose-system",\n "name": "Task.Emc.Compose.System",\n "options": {\n "_taskTimeout": 86400000,\n "action": "compose",\n "endpoints": [\n "ComputeElement0",\n "StorageElement1",\n "StorageElement3"\n ],\n "name": "newSystem"\n },\n "properties": {},\n "runJob": "Job.Emc.Compose.System",\n "state": "failed",\n "taskEndTime": "2016-11-27T13:46:12.185Z",\n "taskStartTime": "2016-11-27T13:46:12.017Z",\n "terminalOnStates": [\n "timeout",\n "cancelled",\n "failed"\n ],\n "waitingOn": {}\n },\n "e8f0b6dd-f3e6-4214-8b9b-48fb8f12bcb9": {\n "friendlyName": "Create Default Pollers",\n "ignoreFailure": false,\n "implementsTask": "Task.Base.Pollers.Redfish.CreateDefault",\n "injectableName": "Task.Inline.Pollers.Redfish.CreateDefault",\n "instanceId": "e8f0b6dd-f3e6-4214-8b9b-48fb8f12bcb9",\n "label": "create-redfish-pollers",\n "name": "Task.Inline.Pollers.Redfish.CreateDefault",\n "options": {\n "_taskTimeout": 86400000,\n "pollers": [\n {\n "config": {\n "command": "systems.logservices"\n },\n "pollInterval": 10000,\n "type": "redfish"\n }\n ]\n },\n "properties": {},\n "runJob": "Job.Pollers.CreateDefault",\n "state": "failed",\n "taskEndTime": "2016-11-27T13:46:12.185Z",\n "terminalOnStates": [\n "succeeded",\n "timeout",\n "cancelled",\n "failed"\n ],\n "waitingOn": {\n "3e9afc11-61b7-45eb-831f-6ee3aa9dd3ad": "succeeded"\n }\n }\n },\n "graph_name": "Graph.Emc.Compose.System",\n "route_id": "bb27e173-0cf3-40d3-bf0b-91b347224331",\n "status": "failed",\n "target": "583ae385e93bf11609015603"\n}\namqp: DEBUG: Closed channel #1\nmodules.worker: INFO: stopping subtask for 583ae385e93bf11609015603\n--------------------- >> end captured logging << ---------------------' |
Contributor
|
BUILD on-taskgraph #1739 : UNSTABLE
BUILD unit-tests #10206 Error Logs ▼Test Name: Task Runner createHeartbeatSubscription should heartbeat Tasks on an interval Error Details: expected 6 to equal 5 Stack Trace: AssertionError: expected 6 to equal 5 at spec/lib/task-runner-spec.js:262:68 at AnonymousObserver._onCompleted (spec/lib/task-runner-spec.js:54:17) at AnonymousObserver.Rx.AnonymousObserver.AnonymousObserver.completed (node_modules/on-core/node_modules/rx/dist/rx.js:1802:12) at AnonymousObserver.Rx.internals.AbstractObserver.AbstractObserver.onCompleted (node_modules/on-core/node_modules/rx/dist/rx.js:1741:14) at AnonymousObserver.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at AutoDetachObserverPrototype.completed (node_modules/on-core/node_modules/rx/dist/rx.js:5807:56) at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onCompleted (node_modules/on-core/node_modules/rx/dist/rx.js:1741:14) at Object.InnerObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:5538:33) at Object.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at AutoDetachObserverPrototype.next (node_modules/on-core/node_modules/rx/dist/rx.js:5793:51) at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at CatchObserver.next (node_modules/on-core/node_modules/rx/dist/rx.js:3292:59) at CatchObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at CatchObserver.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at AutoDetachObserverPrototype.next (node_modules/on-core/node_modules/rx/dist/rx.js:5793:51) at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at InnerObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:3850:90) at InnerObserver.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at AutoDetachObserverPrototype.next (node_modules/on-core/node_modules/rx/dist/rx.js:5793:51) at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at scheduleItem (node_modules/on-core/node_modules/rx/dist/rx.js:3075:16) at JustSink.run (node_modules/on-core/node_modules/rx/dist/rx.js:3083:9) at JustObservable.subscribeCore (node_modules/on-core/node_modules/rx/dist/rx.js:3064:19) at JustObservable.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at setDisposable [as action] (node_modules/on-core/node_modules/rx/dist/rx.js:2038:46) at ScheduledItem.invokeCore (node_modules/on-core/node_modules/rx/dist/rx.js:874:33) at ScheduledItem.invoke (node_modules/on-core/node_modules/rx/dist/rx.js:862:40) at runTrampoline (node_modules/on-core/node_modules/rx/dist/rx.js:1103:37) at tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at CurrentThreadScheduler.schedule (node_modules/on-core/node_modules/rx/dist/rx.js:1119:45) at JustObservable.Rx.ObservableBase.ObservableBase._subscribe (node_modules/on-core/node_modules/rx/dist/rx.js:2051:32) at JustObservable.Rx.Observable.observableProto.subscribe.observableProto.forEach (node_modules/on-core/node_modules/rx/dist/rx.js:1990:19) at MergeAllObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:3819:37) at MergeAllObserver.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at AutoDetachObserverPrototype.next (node_modules/on-core/node_modules/rx/dist/rx.js:5793:51) at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at InnerObserver.Rx.FlatMapObservable.InnerObserver.next (node_modules/on-core/node_modules/rx/dist/rx.js:2101:14) at InnerObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at InnerObserver.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at AutoDetachObserverPrototype.next (node_modules/on-core/node_modules/rx/dist/rx.js:5793:51) at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at InnerObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:3850:90) at InnerObserver.tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at AutoDetachObserverPrototype.next (node_modules/on-core/node_modules/rx/dist/rx.js:5793:51) at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (node_modules/on-core/node_modules/rx/dist/rx.js:1721:31) at scheduleNext (node_modules/on-core/node_modules/rx/dist/rx.js:2407:9) at schedule (node_modules/on-core/node_modules/rx/dist/rx.js:1290:79) at tryCatcher (node_modules/on-core/node_modules/rx/dist/rx.js:63:31) at runTask (node_modules/on-core/node_modules/rx/dist/rx.js:1174:38) at Immediate._onImmediate (node_modules/on-core/node_modules/rx/dist/rx.js:1208:36) |
Member
Author
|
test this please. |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's related with RackHD/on-tasks#374 and RackHD/on-http#531.
@RackHD/corecommitters @panpan0000 @iceiilin