Skip to content

Conversation

@keedya
Copy link
Contributor

@keedya keedya commented Jul 13, 2016

@RackHD/corecommitters @brianparry @zyoung51 @jlongever @tannoa2

andre keedy added 2 commits July 13, 2016 15:46
…into ubuntu-install

Conflicts:
	lib/task-data/tasks/install-ubuntu.js
@yyscamper
Copy link
Contributor

@keedya : As I said in the google group (https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/rackhd/Tx_fd9PQvpQ), please update the schema file accordingly to ensure the integrity of task-schema and task definition.

@keedya
Copy link
Contributor Author

keedya commented Jul 14, 2016

@yyscamper, this PR is to make sure we fix all the errors in Ubuntu installation workflow. I suggest to leave this effort to a different effort in a different story. is that ok with you?

@yyscamper
Copy link
Contributor

@keedya : The task schema change is easy because you just need to add the new options rather than creating a new schema. If move the effort to another story, that story's priority may become low and thus may cause the code divergence for a long time. So I still recommend you to update the schema in this PR.

You can copy The centos schema (https://github.com/RackHD/on-tasks/blob/master/lib/task-data/schemas/install-centos.json#L9), create UbuntuSpecificOptions to contain all your newly add options.

@yyscamper
Copy link
Contributor

@keedya : @WangWinson told me that the failure of Ubuntu installation you encountered is because that we had not tested the ubuntu ISO, our installation testing was using the ubuntu mirror, such as http://archive.ubuntu.com/ubuntu/ .

Thanks for your fix.

@keedya
Copy link
Contributor Author

keedya commented Jul 14, 2016

@yyscamper code updated.
@RackHD/corecommitters @brianparry @jlongever @zyoung51 @tannoa2

@keedya
Copy link
Contributor Author

keedya commented Jul 14, 2016

@yyscamper there was errors that are not related to the ubuntu ISO.
Previous code had 2 major failures and a missed configuration:
1- doesn't setup users correctly and fails ssh validation
2- if encountered partitionned disk, preceed will fail
3- dhcp server setup needed to be documented and changes needed for our vagrant setup(used for our jenkins regression tests)

@brianparry brianparry merged commit eae75f6 into RackHD:master Jul 14, 2016
@yyscamper
Copy link
Contributor

@keedya : Obviously we had missed some test items (#1/#2) even using the ubuntu mirrors. @WangWinson had noticed the problem about #3 but forgot to update the document.

Meanwhile, thanks for your fix of task-schema, that's very good. The only problem is that you forget tomention the kargs in schema. That will not impact the ubuntu workflow because we defaultly allow the additionalProperties, but the task-annotation will not show this option to user. Please complement this if your time is avaiable.

@WangWinson
Copy link
Contributor

For 3, there is a story https://www.pivotaltracker.com/n/projects/1492892/stories/120504923 to track

sushilrai pushed a commit to sushilrai/on-tasks that referenced this pull request Dec 5, 2017
Fix unit test error caused by modification on on-core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants