-
Notifications
You must be signed in to change notification settings - Fork 77
Ubuntu installation #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu installation #280
Conversation
…into ubuntu-install Conflicts: lib/task-data/tasks/install-ubuntu.js
|
@keedya : As I said in the google group (https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/rackhd/Tx_fd9PQvpQ), please update the schema file accordingly to ensure the integrity of task-schema and task definition. |
|
@yyscamper, this PR is to make sure we fix all the errors in Ubuntu installation workflow. I suggest to leave this effort to a different effort in a different story. is that ok with you? |
|
@keedya : The task schema change is easy because you just need to add the new options rather than creating a new schema. If move the effort to another story, that story's priority may become low and thus may cause the code divergence for a long time. So I still recommend you to update the schema in this PR. You can copy The centos schema (https://github.com/RackHD/on-tasks/blob/master/lib/task-data/schemas/install-centos.json#L9), create UbuntuSpecificOptions to contain all your newly add options. |
|
@keedya : @WangWinson told me that the failure of Ubuntu installation you encountered is because that we had not tested the ubuntu ISO, our installation testing was using the ubuntu mirror, such as http://archive.ubuntu.com/ubuntu/ . Thanks for your fix. |
|
@yyscamper code updated. |
|
@yyscamper there was errors that are not related to the ubuntu ISO. |
|
@keedya : Obviously we had missed some test items (#1/#2) even using the ubuntu mirrors. @WangWinson had noticed the problem about #3 but forgot to update the document. Meanwhile, thanks for your fix of task-schema, that's very good. The only problem is that you forget tomention the |
|
For 3, there is a story https://www.pivotaltracker.com/n/projects/1492892/stories/120504923 to track |
Fix unit test error caused by modification on on-core
depends on : Fix Ubuntu installation's workflow on-http#364
@RackHD/corecommitters @brianparry @zyoung51 @jlongever @tannoa2