Fix Ubuntu installation's workflow

[keedya]

• This PR gives the user the choice to install Ubuntu using mounted ISO image or public mirror
• Documentation for this changes will be traced in a different PR

depends on : RackHD/on-tasks#280

@RackHD/corecommitters @jlongever @tannoa2 @uppalk1 @zyoung51

[keedya]

depends on: RackHD/on-tasks#278

[tannoa2]

+1

[leoyjchang]

Add @WangWinson

[yyscamper]

@keedya : Could you please explain what's the problem you are trying to fix?

[keedya]

@yyscamper: Ubuntu workflow didn't install and when I tried to debug it I found the following errors:
1- missing squashfs image
2- if nodes disk is been partitioned prior to the installation, the preceed fails
3- essential package were not available and curl renasar.pub was failing
4- create users script fails every time to set the right password

Finally Isc dhcp server needs 2 options to be added for the Ubuntu installer to accept dhcp offer
Options are:

1. dns-server-option
2. routers option

[tannoa2]

+1

[yyscamper]

@keedya : All you listed problems is critical and should decisively lead to installation failure. But I know both @WangWinson and @cgx027 had verified the ubuntu installation passed, I think they should have already known such big problem if it is true, so I want to understand what's the difference between your case and their.
@WangWinson , @cgx027 : What's your comment for this change?

[keedya]

test this please

[WangWinson]

In @keedya 's issue list above:

1- missing squashfs image
2- if nodes disk is been partitioned prior to the installation, the preceed fails
3- essential package were not available and curl renasar.pub was failing
4- create users script fails every time to set the right password

• 1, if I remember correctly, the squashfs image was once removed from the preseed file in history PR. It works on my side when I test it.
• 2, looks like I haven't cover that case in my dev test. So this could be an issue.
• 3, Not met that issue before.
• 4, should be an issue.

Finally Isc dhcp server needs 2 options to be added for the Ubuntu installer to accept dhcp offer
Options are:

1. dns-server-option
2. routers option

• Yes, this is known issue and I didn't aware of that we packaged dhcpd.conf which could be updated. I think @anhou added this note in readdocs.

[keedya]

@WangWinson : squashfs image can be optional. It is only required when installing Ubuntu from a mounted ISO I can modify the profile to make net image optional
For 3 : fail every time when installing Ubuntu from a mounted ISO

[keedya]

I will submit more changes to allow user to choose between using mounted ISO or public repo

[keedya]

test this please

[WangWinson]

Thanks @keedya . It's clear now, install Ubuntu from mounted ISO not supported previously.

[WangWinson]

👍