add external repo support for CoreOS installation #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
| installDisk: '/dev/sda', | ||
| completionUri: 'pxe-cloud-config.yml' | ||
| completionUri: 'pxe-cloud-config.yml', | ||
| repo: '{{api.server}}/coreos' |
Member
There was a problem hiding this comment.
Will this structure for the repo work as a task definition if we want to support a secondary proxy that's providing access to the data (i.e. an installed instance of squid or such)?
Contributor
Author
There was a problem hiding this comment.
sure, it works, just modify this repo address to the external one while trigger it. This default repo value is just want to gain back compatibility.
Member
|
+1 |
Contributor
Author
|
test this please |
Member
|
+1 |
1 similar comment
Contributor
|
👍 |
yyscamper
added a commit
that referenced
this pull request
Mar 3, 2016
add external repo support for CoreOS installation
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
Adding switich telemtry to default poller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is discussed in this link: RackHD/RackHD#90
Since http proxy often fails for large file transmission especially in vagrant environment, so add the external repo support will provide alternative way to do CoreOS installation.
Merge after RackHD/on-http#146
@RackHD/corecommitters @pengz1 @heckj