-
Notifications
You must be signed in to change notification settings - Fork 77
add external repo support for CoreOS installation #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 |
|
👍 @RackHD/corecommitters question related to this kind of change - how should we add documentation to existing structures like this to share that we're made new variables like this that need to be accommodated by any workflows invoking them? |
|
@heckj : I think this is not a kind of new variable, because CentOS/RHEL/ESXi has already supported such option. I consider this as a technical debt. We need to sync our all OS bootstrap design, I see we already have an issue opened for this: https://github.com/RackHD/RackHD/issues/50. If this issue is resolved, then a common document will cover all OS bootstrap for these common features. In future, we may find some feature is hard to be added into other OS, like CoreOS may not support kvm, and Other OS excepts ESXi cannot support to configure the virtual switch, so we do need a separated document for each OS to describe those special features. |
|
+1 |
|
test this please |
|
|
Fyi..The unit test fixes included in this PR #157 resolves random port conflicts introduced in the 1.1 authentication commits. |
|
@jlongever , thanks for this info, so I can ignore the Jenkins failure. |
|
test this please |
|
|
👍 |
add external repo support for CoreOS installation
This is discussed in this link: https://github.com/RackHD/RackHD/issues/90
Since http proxy often fails for large file transmission especially in vagrant environment, so add the external repo support will provide alternative way to do CoreOS installation.
@RackHD/corecommitters @pengz1 @heckj