Skip to content

To delete obsoleted OBM API from swagger ui #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sunnyqianzhang wants to merge 2 commits into from
Closed

To delete obsoleted OBM API from swagger ui #765

sunnyqianzhang wants to merge 2 commits into from

Conversation

@sunnyqianzhang
Copy link
Member

@sunnyqianzhang sunnyqianzhang commented Sep 6, 2017

GET/PUT /nodes/{identifier}/obm has been replaced with new API, so swagger ui shouldn't show this to users. This code review deleted the obsoleted @iceiilin @anhou @pengz1

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Sep 6, 2017

BUILD on-http #497 : FAILURE

BUILD on-http #497 Error Logs ▼Test Name: 2.0 Http.Api.Nodes OBM support should call getObmsByNodeId Error Details: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" Response body: {} Error: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" at Test._assertHeader (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" at Test._assertHeader (node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)

Test Name: 2.0 Http.Api.Nodes OBM support should call putObmsByNodeId
Error Details: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8" Response body: {} Error: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8" at Test._assertHeader (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build-deps/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17)
Stack Trace: Error: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8"
at Test._assertHeader (node_modules/supertest/lib/test.js:213:45)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:923:12)

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Sep 7, 2017

BUILD on-http #505 : FAILURE

BUILD on-http #505 Error Logs ▼Test Name: should call getObmsByNodeId Error Details: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" Response body: {} Error: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" at Test._assertHeader (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" at Test._assertHeader (node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)

Test Name: should call putObmsByNodeId
Error Details: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8" Response body: {} Error: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8" at Test._assertHeader (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17)
Stack Trace: Error: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8"
at Test._assertHeader (node_modules/supertest/lib/test.js:213:45)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:923:12)

@sunnyqianzhang
Copy link
Member Author

sunnyqianzhang commented Sep 7, 2017

test this please

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Sep 7, 2017

BUILD on-http #511 : FAILURE

BUILD on-http #511 Error Logs ▼Test Name: should call getObmsByNodeId Error Details: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" Response body: {} Error: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" at Test._assertHeader (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17) Stack Trace: Error: expected "Content-Type" matching /^application\/json/, got "text/html; charset=utf-8" at Test._assertHeader (node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (node_modules/supertest/lib/test.js:247:11) at Test.assert (node_modules/supertest/lib/test.js:148:18) at assert (node_modules/supertest/lib/test.js:127:12) at node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at endReadableNT (_stream_readable.js:923:12)

Test Name: should call putObmsByNodeId
Error Details: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8" Response body: {} Error: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8" at Test._assertHeader (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:213:45) at Test._assertFunction (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:247:11) at Test.assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:148:18) at assert (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:127:12) at /home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/lib/test.js:124:5 at Test.Request.callback (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3) at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/b/on-http/node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:923:12) at nextTickCallbackWith2Args (node.js:458:9) at process._tickDomainCallback (node.js:413:17)
Stack Trace: Error: expected "Content-Type" matching /^application/json/, got "text/html; charset=utf-8"
at Test._assertHeader (node_modules/supertest/lib/test.js:213:45)
at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
at Test.assert (node_modules/supertest/lib/test.js:148:18)
at assert (node_modules/supertest/lib/test.js:127:12)
at node_modules/supertest/lib/test.js:124:5
at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:703:3)
at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:922:12)
at endReadableNT (_stream_readable.js:923:12)

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Sep 7, 2017

BUILD on-http #512 : FAILURE

BUILD on-http #512 Error Logs ▼Test Name: test_node_put_obm_by_node_id Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '181', 'Content-Security-Policy': "default-src 'self'", 'X-Content-Type-Options': 'nosniff', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'Date': 'Thu, 07 Sep 2017 07:56:04 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'text/html; charset=utf-8'}) HTTP response body: <title>Error</title> 
Cannot PUT /api/2.0/nodes/59b0fb9441424d47015ab447/obm

-------------------- >> begin captured logging << --------------------
infra.run: DEBUG: relaying set_test((None,)) to all trackers {}
test.run: DEBUG: handle_after_test pluggin progression for <stream_sources.amqp_source.AMQPStreamMonitor object at 0x7fede8102c50> test=test_node_tags_masterDel (nodes_tests.NodesTests)
test.run: DEBUG: handle_after_test pluggin progression for <stream_sources.self_test_source.SelfTestStreamMonitor object at 0x7fede8146f90> test=test_node_tags_masterDel (nodes_tests.NodesTests)
root: INFO: +1.48 - STARTING TEST: [test_node_put_obm_by_node_id (nodes_tests.NodesTests)]
infra.run: DEBUG: relaying set_test((Test(<nodes_tests.NodesTests testMethod=test_node_put_obm_by_node_id>),)) to all trackers {}
test.run: DEBUG: handle_start_test pluggin progression for <stream_sources.amqp_source.AMQPStreamMonitor object at 0x7fede8102c50> test=test_node_put_obm_by_node_id (nodes_tests.NodesTests)
test.run: DEBUG: handle_start_test pluggin progression for <stream_sources.self_test_source.SelfTestStreamMonitor object at 0x7fede8146f90> test=test_node_put_obm_by_node_id (nodes_tests.NodesTests)
test.run: INFO: Creating test node (name=test_switch_node)
test.run: INFO: Creating test node (name=test_mgmt_node)
test.run: INFO: Creating test node (name=test_pdu_node)
test.run: INFO: Creating test node (name=test_enclosure_node)
test.run: INFO: Creating test node (name=test_compute_node)
test.run: INFO: Node to put obm: 59b0fb9441424d47015ab447 test_compute_node
test.run: DEBUG: {
"catalogs": "/api/2.0/nodes/59b0fb9441424d47015ab447/catalogs",
"name": "test_compute_node",
"tags": "/api/2.0/nodes/59b0fb9441424d47015ab447/tags",
"workflows": "/api/2.0/nodes/59b0fb9441424d47015ab447/workflows",
"identifiers": [
"FF:FF:FF:05"
],
"relations": [],
"autoDiscover": false,
"obms": [],
"pollers": "/api/2.0/nodes/59b0fb9441424d47015ab447/pollers",
"type": "compute",
"id": "59b0fb9441424d47015ab447",
"ibms": []
}
--------------------- >> end captured logging << ---------------------
Stack Trace: File "/usr/lib/python2.7/unittest/case.py", line 331, in run
testMethod()
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/FIT/local/lib/python2.7/site-packages/nosedep.py", line 126, in inner
return func(args, **kwargs)
File "/home/jenkins/workspace/on-http/RackHD/test/tests/api-cit/v2_0/nodes_tests.py", line 370, in test_node_put_obm_by_node_id
Api().nodes_put_obms_by_node_id(identifier=n.get('id'), body=test_obm)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/FIT/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 2026, in nodes_put_obms_by_node_id
callback=params.get('callback'))
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/FIT/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
response_type, auth_settings, callback)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/FIT/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
post_params=post_params, body=body)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/FIT/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 364, in request
body=body)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/FIT/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 215, in PUT
body=body)
File "/home/jenkins/workspace/on-http/RackHD/test/.venv/FIT/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
raise ApiException(http_resp=r)
'(404)\nReason: Not Found\nHTTP response headers: HTTPHeaderDict({'Content-Length': '181', 'Content-Security-Policy': "default-src 'self'", 'X-Content-Type-Options': 'nosniff', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'Date': 'Thu, 07 Sep 2017 07:56:04 GMT', 'Access-Control-Allow-Origin': '', 'Content-Type': 'text/html; charset=utf-8'})\nHTTP response body: \n\n\n\n<title>Error</title>\n\n\n

Cannot PUT /api/2.0/nodes/59b0fb9441424d47015ab447/obm
\n\n\n\n\n-------------------- >> begin captured logging << --------------------\ninfra.run: DEBUG: relaying set_test((None,)) to all trackers {}\ntest.run: DEBUG: handle_after_test pluggin progression for <stream_sources.amqp_source.AMQPStreamMonitor object at 0x7fede8102c50> test=test_node_tags_masterDel (nodes_tests.NodesTests)\ntest.run: DEBUG: handle_after_test pluggin progression for <stream_sources.self_test_source.SelfTestStreamMonitor object at 0x7fede8146f90> test=test_node_tags_masterDel (nodes_tests.NodesTests)\nroot: INFO: +1.48 - STARTING TEST: [test_node_put_obm_by_node_id (nodes_tests.NodesTests)]\ninfra.run: DEBUG: relaying set_test((Test(<nodes_tests.NodesTests testMethod=test_node_put_obm_by_node_id>),)) to all trackers {}\ntest.run: DEBUG: handle_start_test pluggin progression for <stream_sources.amqp_source.AMQPStreamMonitor object at 0x7fede8102c50> test=test_node_put_obm_by_node_id (nodes_tests.NodesTests)\ntest.run: DEBUG: handle_start_test pluggin progression for <stream_sources.self_test_source.SelfTestStreamMonitor object at 0x7fede8146f90> test=test_node_put_obm_by_node_id (nodes_tests.NodesTests)\ntest.run: INFO: Creating test node (name=test_switch_node)\ntest.run: INFO: Creating test node (name=test_mgmt_node)\ntest.run: INFO: Creating test node (name=test_pdu_node)\ntest.run: INFO: Creating test node (name=test_enclosure_node)\ntest.run: INFO: Creating test node (name=test_compute_node)\ntest.run: INFO: Node to put obm: 59b0fb9441424d47015ab447 test_compute_node \ntest.run: DEBUG: {\n "catalogs": "/api/2.0/nodes/59b0fb9441424d47015ab447/catalogs", \n "name": "test_compute_node", \n "tags": "/api/2.0/nodes/59b0fb9441424d47015ab447/tags", \n "workflows": "/api/2.0/nodes/59b0fb9441424d47015ab447/workflows", \n "identifiers": [\n "FF:FF:FF:05"\n ], \n "relations": [], \n "autoDiscover": false, \n "obms": [], \n "pollers": "/api/2.0/nodes/59b0fb9441424d47015ab447/pollers", \n "type": "compute", \n "id": "59b0fb9441424d47015ab447", \n "ibms": []\n}\n--------------------- >> end captured logging << ---------------------'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunnyqianzhang @JenkinsRHD