Script to enable interfaces inorder to send/receive LLDP #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please squash and rebase the commits. |
Contributor
|
Requires #512 |
Contributor
Author
|
Thanks, just did. |
yyscamper
reviewed
Oct 27, 2016
| ip= 100+count | ||
| string += "auto " + subdirname | ||
| string += "\niface " + subdirname +" inet static" | ||
| string += "\naddress 10.0.0." + str(ip) |
Contributor
There was a problem hiding this comment.
@mtannous : please confirm the arbitrary IP address is OK for LLDP?
Contributor
Author
There was a problem hiding this comment.
@yyscamper yes having the arbitrary IP address is fine for LLDP. I verified and this is just to get the interface up
Contributor
There was a problem hiding this comment.
@mtannous : please add some comment, so other developer will be aware of this is not a magic IP address, actually any one is OK.
yyscamper
approved these changes
Oct 28, 2016
Contributor
|
jenkins: ok to test |
yyscamper
reviewed
Nov 3, 2016
data/templates/set_interfaces.py
Outdated
| for dirname, dirnames, filenames in os.walk('/sys/class/net/'): | ||
| for subdirname in dirnames: | ||
| if subdirname != "lo": | ||
| //Here we are assigning an arbitrary IP which could be a different one. This is just to get the interface up |
Contributor
There was a problem hiding this comment.
@mtannous : for python, the comment symbol is # not //
yyscamper
approved these changes
Nov 3, 2016
Contributor
|
Can this be merged please :-) |
Member
|
test this please |
rolandpoulter
approved these changes
Jan 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script iterates through all the interfaces in the microkernel and sets their default IP address, netmask, gateway. Once all the interfaces are set, then the script makes sure that all interfaces are up.
Referencing this pull request:
RackHD/on-tasks#367