-
Notifications
You must be signed in to change notification settings - Fork 77
updating postNode w/ new snmpSettings #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
BUILD on-http #3185 : FAILURE
BUILD unit-tests #11458 Error Logs ▼Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a list of the node's ssh settings Error Details: Cannot read property 'findAllByNode' of undefined Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:383:27)Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a 404 if the node has no ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should replace existing settings with a new set of ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should add a new set of ssh settings if none exist Test Name: Http.Api.Ibms /api/2.0/ibms should return a list of IBM instances Test Name: Http.Api.Ibms /api/2.0/ibms should put an IBM instance Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with unloaded schema Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with missing field Test Name: Http.Api.Ibms /api/2.0/ibms/:id "before each" hook for "should get an IBM instance" Test Name: Http.Api.Ibms /api/2.0/ibms/:id "after each" hook for "should get an IBM instance" |
lib/services/nodes-api-service.js
Outdated
| "service": "snmp-ibm-service", | ||
| "config": snmpBody | ||
| }; | ||
| return waterline.ibms.upsertByNode(node.id, snmpIbm); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent
fb089c8 to
b06e703
Compare
|
BUILD on-http #3196 : FAILURE
BUILD unit-tests #11489 Error Logs ▼Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a list of the node's ssh settings Error Details: Cannot read property 'findAllByNode' of undefined Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:383:27)Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a 404 if the node has no ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should replace existing settings with a new set of ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should add a new set of ssh settings if none exist Test Name: Http.Api.Ibms /api/2.0/ibms should return a list of IBM instances Test Name: Http.Api.Ibms /api/2.0/ibms should put an IBM instance Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with unloaded schema Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with missing field Test Name: Http.Api.Ibms /api/2.0/ibms/:id "before each" hook for "should get an IBM instance" Test Name: Http.Api.Ibms /api/2.0/ibms/:id "after each" hook for "should get an IBM instance" |
b06e703 to
4ac5ec0
Compare
4ac5ec0 to
5e4e019
Compare
|
BUILD on-http #3198 : FAILURE
BUILD unit-tests #11499 Error Logs ▼Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a list of the node's ssh settings Error Details: Cannot read property 'findAllByNode' of undefined Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:383:27)Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a 404 if the node has no ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should replace existing settings with a new set of ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should add a new set of ssh settings if none exist Test Name: Http.Api.Ibms /api/2.0/ibms should return a list of IBM instances Test Name: Http.Api.Ibms /api/2.0/ibms should put an IBM instance Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with unloaded schema Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with missing field Test Name: Http.Api.Ibms /api/2.0/ibms/:id "before each" hook for "should get an IBM instance" Test Name: Http.Api.Ibms /api/2.0/ibms/:id "after each" hook for "should get an IBM instance" |
|
BUILD on-http #3199 : FAILURE
BUILD unit-tests #11500 Error Logs ▼Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a list of the node's ssh settings Error Details: Cannot read property 'findAllByNode' of undefined Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:383:27)Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a 404 if the node has no ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should replace existing settings with a new set of ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should add a new set of ssh settings if none exist Test Name: Http.Api.Ibms /api/2.0/ibms should return a list of IBM instances Test Name: Http.Api.Ibms /api/2.0/ibms should put an IBM instance Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with unloaded schema Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with missing field Test Name: Http.Api.Ibms /api/2.0/ibms/:id "before each" hook for "should get an IBM instance" Test Name: Http.Api.Ibms /api/2.0/ibms/:id "after each" hook for "should get an IBM instance" |
|
|
||
| var ibms = Promise.map(waterline.obms.find({node: node.id}), function(ibm { | ||
| return _.pick(ibm.toJSON(), 'service', 'config'); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected an identifier and instead saw ')'.
| .spread(function(obms, sshSettings) { | ||
|
|
||
| var ibms = Promise.map(waterline.obms.find({node: node.id}), function(ibm { | ||
| return _.pick(ibm.toJSON(), 'service', 'config'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected an identifier and instead saw 'return'.
Expected ')' and instead saw '_'.
lib/api/1.1/northbound/nodes.js
Outdated
| return Promise.all([obms, sshSettings]) | ||
| .spread(function(obms, sshSettings) { | ||
|
|
||
| var ibms = Promise.map(waterline.obms.find({node: node.id}), function(ibm { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected ')' to match '(' from line 61 and instead saw '{'.
'function closure expressions' is only available in Mozilla JavaScript extensions (use moz option).
'ibm' is defined but never used.
'ibms' is defined but never used.
|
BUILD on-http #3211 : FAILURE
|
|
BUILD on-http #3219 : FAILURE
BUILD unit-tests #11524 Error Logs ▼Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a list of the node's ssh settings Error Details: Cannot read property 'findAllByNode' of undefined Stack Trace: TypeError: Cannot read property 'findAllByNode' of undefined at Context.<anonymous> (spec/lib/api/2.0/nodes-spec.js:383:27)Test Name: 2.0 Http.Api.Nodes GET /nodes/:identifier/ssh should return a 404 if the node has no ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should replace existing settings with a new set of ssh settings Test Name: 2.0 Http.Api.Nodes POST /nodes/:identifier/ssh should add a new set of ssh settings if none exist Test Name: Http.Api.Ibms /api/2.0/ibms should return a list of IBM instances Test Name: Http.Api.Ibms /api/2.0/ibms should put an IBM instance Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with unloaded schema Test Name: Http.Api.Ibms /api/2.0/ibms should 400 when put with missing field Test Name: Http.Api.Ibms /api/2.0/ibms/:id "before each" hook for "should get an IBM instance" Test Name: Http.Api.Ibms /api/2.0/ibms/:id "after each" hook for "should get an IBM instance" |
brianparry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
changing post node so it doesn't use old snmpSettings from node
@RackHD/veyron