addressing PR comments #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyAbildgaard
force-pushed
the
feature/ibms
branch
from
cde0373 to
a0a0d1b
Compare
Contributor
|
BUILD on-core #1066 : FAILURE
|
Contributor
|
BUILD on-core #1067 : FAILURE
|
yyscamper
approved these changes
Feb 1, 2017
Contributor
yyscamper
left a comment
yyscamper
left a comment
There was a problem hiding this comment.
Please don't forget to change the function that manual add new node: https://github.com/RackHD/on-http/blob/master/lib/services/nodes-api-service.js#L286
Author
|
@yyscamper you can see my PR for those changes here: |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing snmpSettings from lib/model/node.js
snmpSettings are moved from node to ibms
@RackHD/veyron