Skip to content

Refactor 2.0 API pollers route. #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brianparry wants to merge 1 commit into from
Closed

Refactor 2.0 API pollers route. #259

brianparry wants to merge 1 commit into from

Conversation

@brianparry
Copy link
Contributor

@brianparry brianparry commented Apr 28, 2016

  • Remove the use of serializer/deserializers
  • Add view and schema for pollers

Depends on RackHD/on-core#126

Refactor 2.0 API pollers route.
516ee32 
* Remove the use of serializer/deserializers
* Add view and schema for pollers
* Requires changes to work-item model in on-core
houndci-bot
houndci-bot reviewed Apr 28, 2016
View reviewed changes
lib/services/pollers-api-service.js
Errors,
_
_,
Promise
Copy link

@houndci-bot houndci-bot Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Promise' is defined but never used.

Copy link

@houndci-bot houndci-bot Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Promise' is defined but never used.

@JenkinsRHD
Copy link
Contributor

JenkinsRHD commented Apr 28, 2016 

*** BUILD #1079 ***
Test Name: Redfish Event Service should submit test event
Error Details: expected 200 "OK", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 200 "OK", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 200 "OK", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Redfish Event Service should delete a valid subscription
Error Details: expected 200 "OK", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 200 "OK", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 200 "OK", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Redfish Session Service session login "after each" hook: delete session object for "should return the session"
Error Details: expected 204 "No Content", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 204 "No Content", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 204 "No Content", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Nodes DELETE /nodes/:identifier/workflows/active should delete the currently active workflow
Error Details: expected 204 "No Content", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 204 "No Content", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 204 "No Content", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Internal.Files DELETE /files/{fileidentifier} should delete file by uuid
Error Details: expected 204 "No Content", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 204 "No Content", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 204 "No Content", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Pollers should create an IPMI poller with POST /pollers
Error Details: expected 201 "Created", got 400 "Bad Request" Response body: { message: '[Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to workitems:\n • name\n   • `undefined` should be a string (instead of "null", which is a object)\n   • "required" validation rule failed for input: null\nSpecifically, it threw an error.  Details:\n undefined\n' } Error: expected 201 "Created", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 201 "Created", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Pollers should create an SNMP poller with POST /pollers
Error Details: expected 201 "Created", got 400 "Bad Request" Response body: { message: '[Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to workitems:\n • name\n   • `undefined` should be a string (instead of "null", which is a object)\n   • "required" validation rule failed for input: null\nSpecifically, it threw an error.  Details:\n undefined\n' } Error: expected 201 "Created", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 201 "Created", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Pollers POST /pollers afterwards "before each" hook for "should contain the new poller in GET /pollers"
Error Details: expected 201 "Created", got 400 "Bad Request" Response body: { message: '[Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to workitems:\n • name\n   • `undefined` should be a string (instead of "null", which is a object)\n   • "required" validation rule failed for input: null\nSpecifically, it threw an error.  Details:\n undefined\n' } Error: expected 201 "Created", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 201 "Created", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Views 2.0 Views should delete a view
Error Details: expected 204 "No Content", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 204 "No Content", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 204 "No Content", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Workflows.2.0 workflowsDeleteById should delete the Task with DELETE /workflows/id
Error Details: expected 200 "OK", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 200 "OK", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 200 "OK", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.workflowTasks.2.0 workflowsDeleteTasksByName should delete the Task with DELETE /workflows/tasks/injectableName
Error Details: expected 200 "OK", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 200 "OK", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 200 "OK", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Tasks GET /tasks/:id should return 204 if no active task exists
Error Details: expected 204 "No Content", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 204 "No Content", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 204 "No Content", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Tasks POST /tasks/:id should accept a large entity response
Error Details: expected 201 "Created", got 400 "Bad Request" Response body: { message: 'Cannot read property \'toJSON\' of undefined' } Error: expected 201 "Created", got 400 "Bad Request"     at Test.assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:205:15)     at assert (/home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:132:12)     at /home/jenkins/workspace/on-http/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/home/jenkins/workspace/on-http/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 201 "Created", got 400 "Bad Request"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Services.Http.Swagger renderer() should render a collection of objects()
Error Details: expected send to have been called with arguments [{"message":"foo"},{"message":"bar"}]     send([{"message":"bar"},{"message":"bar"}]) at /home/jenkins/workspace/on-http/build/lib/services/swagger-api-service.js:9:10448
Stack Trace: AssertionError: expected send to have been called with arguments [{"message":"foo"},{"message":"bar"}]
    send([{"message":"bar"},{"message":"bar"}]) at lib/services/swagger-api-service.js:9:10448
    at spec/lib/services/swagger-api-service-spec.js:492:36
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Promise._settlePromises (node_modules/on-core/node_modules/bluebird/js/main/promise.js:697:14)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:123:16)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

Test Name: test_do_logout_session
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '56', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"38-1THEe6zZQleMpMqNU8YyhQ"', 'Date': 'Thu, 28 Apr 2016 22:38:04 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Cannot read property 'toJSON' of undefined"}

Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/redfish_1_0/session_service_tests.py", line 105, in test_do_logout_session
    redfish().do_logout_session(self.__session)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/apis/redfishv_api.py", line 2674, in do_logout_session
    callback=params.get('callback'))
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 374, in request
    headers=headers)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 201, in DELETE
    query_params=query_params)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '56', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"38-1THEe6zZQleMpMqNU8YyhQ"', 'Date': 'Thu, 28 Apr 2016 22:38:04 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Cannot read property 'toJSON' of undefined"}



Test Name: test_node_workflows_post
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '56', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"38-1THEe6zZQleMpMqNU8YyhQ"', 'Date': 'Thu, 28 Apr 2016 22:38:10 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Cannot read property 'toJSON' of undefined"}

Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 314, in test_node_workflows_post
    timeout = self.__post_workflow(id,'Graph.Discovery')
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 94, in __post_workflow
    status = self.__get_workflow_status(id)
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 84, in __get_workflow_status
    Api().nodes_get_active_workflow_by_id(identifier=id)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 2904, in nodes_get_active_workflow_by_id
    callback=params.get('callback'))
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 342, in request
    headers=headers)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 184, in GET
    query_params=query_params)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '56', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"38-1THEe6zZQleMpMqNU8YyhQ"', 'Date': 'Thu, 28 Apr 2016 22:38:10 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Cannot read property 'toJSON' of undefined"}



Test Name: test_node_delete
Error Details: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Content-Length': '89', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"59-MDOFTaS4N+ijzy0aeH/iDA"', 'Date': 'Thu, 28 Apr 2016 22:38:11 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"NotFoundError: Could not find node with identifier 572290d29b1a10d00707883b"}

-------------------- >> begin captured logging << --------------------
tests.api.v2_0.nodes_tests: INFO: Deleting node 572290d29b1a10d00707883b (name=test_compute_node)
tests.api.v2_0.nodes_tests: INFO: Deleting node 572290d29b1a10d00707883b (name=test_compute_node)
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 255, in test_node_delete
    Api().nodes_del_by_id(identifier=uuid)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 1756, in nodes_del_by_id
    callback=params.get('callback'))
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 374, in request
    headers=headers)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 201, in DELETE
    query_params=query_params)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
'(404)\nReason: Not Found\nHTTP response headers: HTTPHeaderDict({\'Content-Length\': \'89\', \'X-Powered-By\': \'Express\', \'Connection\': \'keep-alive\', \'ETag\': \'W/"59-MDOFTaS4N+ijzy0aeH/iDA"\', \'Date\': \'Thu, 28 Apr 2016 22:38:11 GMT\', \'Access-Control-Allow-Origin\': \'*\', \'Content-Type\': \'application/json; charset=utf-8\'})\nHTTP response body: {"message":"NotFoundError: Could not find node with identifier 572290d29b1a10d00707883b"}\n\n-------------------- >> begin captured logging << --------------------\ntests.api.v2_0.nodes_tests: INFO: Deleting node 572290d29b1a10d00707883b (name=test_compute_node)\ntests.api.v2_0.nodes_tests: INFO: Deleting node 572290d29b1a10d00707883b (name=test_compute_node)\n--------------------- >> end captured logging << ---------------------'

Test Name: create_pollers
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '306', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"132-H9VNJbNENqMf7mUWs03rgA"', 'Date': 'Thu, 28 Apr 2016 22:38:13 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"[Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to workitems:\n • name\n   • `undefined` should be a string (instead of \"null\", which is a object)\n   • \"required\" validation rule failed for input: null\nSpecifically, it threw an error.  Details:\n undefined\n"}

Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/pollers_tests.py", line 113, in create_pollers
    Api().pollers_post(poller)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/apis/api_api.py", line 3287, in pollers_post
    callback=params.get('callback'))
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/api_client.py", line 358, in request
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 208, in POST
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_api2_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '306', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"132-H9VNJbNENqMf7mUWs03rgA"', 'Date': 'Thu, 28 Apr 2016 22:38:13 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"[Error (E_VALIDATION) 1 attribute is invalid] Invalid attributes sent to workitems:\n • name\n   • `undefined` should be a string (instead of \"null\", which is a object)\n   • \"required\" validation rule failed for input: null\nSpecifically, it threw an error.  Details:\n undefined\n"}



Test Name: test_tags_del
Error Details: local variable 'updated_tags' referenced before assignment
-------------------- >> begin captured logging << --------------------
tests.api.v2_0.tags_tests: INFO: Deleting tag that was created in Testing POST:/api/2.0/tags/ 
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/tags_tests.py", line 108, in test_tags_del
    assert_equal([],updated_tags, message='Tags were not deleted successfully')
"local variable 'updated_tags' referenced before assignment\n-------------------- >> begin captured logging << --------------------\ntests.api.v2_0.tags_tests: INFO: Deleting tag that was created in Testing POST:/api/2.0/tags/ \n--------------------- >> end captured logging << ---------------------"

Test Name: test_submit_test_event
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '56', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"38-1THEe6zZQleMpMqNU8YyhQ"', 'Date': 'Thu, 28 Apr 2016 22:38:17 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Cannot read property 'toJSON' of undefined"}

-------------------- >> begin captured logging << --------------------
modules.httpd: INFO: Starting httpd server on 0.0.0.0 port 9010
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/redfish_1_0/event_service_tests.py", line 95, in test_submit_test_event
    redfish().test_event(body={})
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/apis/redfishv_api.py", line 1197, in test_event
    callback=params.get('callback'))
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 322, in call_api
    response_type, auth_settings, callback)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 149, in __call_api
    post_params=post_params, body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/api_client.py", line 358, in request
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 208, in POST
    body=body)
  File "/tmp/.venv/local/lib/python2.7/site-packages/on_http_redfish_1_0/rest.py", line 177, in request
    raise ApiException(http_resp=r)
'(400)\nReason: Bad Request\nHTTP response headers: HTTPHeaderDict({\'Content-Length\': \'56\', \'X-Powered-By\': \'Express\', \'Connection\': \'keep-alive\', \'ETag\': \'W/"38-1THEe6zZQleMpMqNU8YyhQ"\', \'Date\': \'Thu, 28 Apr 2016 22:38:17 GMT\', \'Access-Control-Allow-Origin\': \'*\', \'Content-Type\': \'application/json; charset=utf-8\'})\nHTTP response body: {"message":"Cannot read property \'toJSON\' of undefined"}\n\n-------------------- >> begin captured logging << --------------------\nmodules.httpd: INFO: Starting httpd server on 0.0.0.0 port 9010\n--------------------- >> end captured logging << ---------------------'

@brianparry brianparry closed this Apr 29, 2016
BillyAbildgaard pushed a commit to BillyAbildgaard/on-http that referenced this pull request Jun 28, 2016
fixing issue RackHD#259 and unit test cleanup
af90ae5
brianparry pushed a commit that referenced this pull request Jun 30, 2016
Merge pull request #346 from BillyAbildgaard/bug/unit-test-cleanup
d7f1c88 
fixing issue #259 and unit test cleanup
@JenkinsRHD JenkinsRHD mentioned this pull request Jun 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianparry @JenkinsRHD @houndci-bot