Skip to content

Conversation

@brianparry
Copy link
Contributor

This patch includes changes to the work-item model that are needed to remove serializables from the 2.0 API pollers route. Changes convert the pollers resource "type" property to "name" and redact passwords from poller config.

Brian Parry added 2 commits April 28, 2016 16:53
* Add beforeValidate lifecycle callback to change poller type to name.
* Use toJSON to redact fields from poller config.
expect(items.length).to.equal(1);
expect(items[0].name).to.equal('Pollers.IPMI');
expect(items[0]).not.to.have.property('type');
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@JenkinsRHD
Copy link
Contributor

*** BUILD #478 ***
Test Name: create_pollers
Error Details: {'password': 'admin', 'command': 'sdr', 'user': 'admin'} != {u'command': u'sdr', u'user': u'admin'}
Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-core/RackHD/test/tests/api/v2_0/pollers_tests.py", line 119, in create_pollers
    assert_equal(poller[key], data[key])
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
AssertionError: {'password': 'admin', 'command': 'sdr', 'user': 'admin'} != {u'command': u'sdr', u'user': u'admin'}


@brianparry brianparry closed this Apr 29, 2016
dalebremner pushed a commit to dalebremner/on-core that referenced this pull request Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants