Skip to content

Conversation

@jlongever
Copy link
Contributor

Add 'tags' to nodes to identify groups of nodes by arbitrary tag names
Add 1.1 and 2.0 paths for new /nodes and /tags routes.

This is on @zyoung51's behalf, resolves merge conflicts from #135, which can be closed.
@RackHD/corecommitters @uppalk1 @tannoa2 @keedya @zyoung51

Zack Young added 2 commits February 26, 2016 10:07
- Add 'tags' to nodes to identify groups of nodes by arbitrary tag names
- Add 1.1 and 2.0 paths for new /nodes and /tags routes.
@jlongever jlongever mentioned this pull request Feb 26, 2016
@brianparry
Copy link
Contributor

👍

@jlongever
Copy link
Contributor Author

test this please

@JenkinsRHD
Copy link
Contributor

*** BUILD #505 ***
Test Name: test_workflowTasks_put
Error Details: Soft Reset Node != fn_1
-------------------- >> begin captured logging << --------------------
tests.api.v1_1.workflowTasks_tests: INFO: Adding workflow task : {'friendlyName': 'fn_1', 'injectableName': 'in_1', 'properties': {}, 'options': {}, 'implementsTask': 'im_1'}
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/usr/local/lib/python2.7/dist-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/var/lib/jenkins/jobs/on-http/workspace/RackHD/test/tests/api/v1_1/workflowTasks_tests.py", line 84, in test_workflowTasks_put
    assert_equal(readFriendlyName,self.workflowTaskDict.get('friendlyName'))
  File "/usr/local/lib/python2.7/dist-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
"Soft Reset Node != fn_1\n-------------------- >> begin captured logging << --------------------\ntests.api.v1_1.workflowTasks_tests: INFO: Adding workflow task : {'friendlyName': 'fn_1', 'injectableName': 'in_1', 'properties': {}, 'options': {}, 'implementsTask': 'im_1'}\n--------------------- >> end captured logging << ---------------------"

@zyoung51
Copy link
Contributor

Good stuff. +1

@jlongever
Copy link
Contributor Author

test this please

@jlongever
Copy link
Contributor Author

+1. Checks are good, based on previous PR #135 +1's I'm going to merge.

jlongever added a commit that referenced this pull request Feb 26, 2016
@jlongever jlongever merged commit 4549749 into RackHD:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants