Node Tagging #135

zyoung51 · 2016-02-18T14:21:52Z

Add 'tags' to nodes to identify groups of nodes by arbitrary tag names
Add 1.1 and 2.0 paths for new /nodes and /tags routes.

houndci-bot · 2016-02-18T14:22:49Z

lib/api/2.0/tags.js

+    return nodes.getNodesByTag(req.swagger.params.tagName.value);
+});
+
+var postWorkflowById = controller({success: 202}, function(req, res) {


'res' is defined but never used.

zyoung51 · 2016-02-18T14:22:58Z

@RackHD/corecommitters @uppalk1 @keedya @tannoa2
Depends on RackHD/on-core#88, RackHD/on-taskgraph#62

JenkinsRHD · 2016-02-18T14:49:30Z

*** BUILD #400 ***
Test Name: Http.Api.Tags "before all" hook: start HTTP server
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
    at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
    at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
    at spec/lib/api/1.1/tags-spec.js:41:19
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

Test Name: Http.Api.Tags "after all" hook: stop HTTP server
Error Details: Cannot read property 'find' of undefined
Stack Trace: TypeError: Cannot read property 'find' of undefined
    at spec/lib/api/1.1/tags-spec.js:62:27
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

anhou · 2016-02-18T15:26:30Z

lib/api/1.1/northbound/nodes.js

+        }
+    }));
+
+    router.delete('/nodes/:identifier/tags/:name', rest(function(req) {


need annotations, v1.1 api apidoc, and python-client is based on router's annotations.

WangWinson · 2016-02-19T04:01:42Z

General question, does add new API route cause a API version bump ?

anhou · 2016-02-19T10:13:49Z

👍 after fix annotation, unused 'res', travisCI failure, and if others have no concerns about promise assertion

jlongever · 2016-02-19T13:41:19Z

test this please

JenkinsRHD · 2016-02-19T14:27:52Z

*** BUILD #409 ***

zyoung51 · 2016-02-19T18:53:03Z

@RackHD/corecommitters Can you answer Winson's question above?

jlongever · 2016-02-19T19:24:59Z

@WangWinson

http://rackhd.readthedocs.org/en/latest/devguide/index.html#api-versioning-conventions

Specifically:

8.3.3. API Version Guidelines
Use the following guide lines when determining if a new API version is needed.

The following changes require a new API version:

changing the semantic meaning of a URI route
removing a URI route

The following changes do not require a new API version:

adding an entirely new URI route
changing the query parameters (pagination, filtering, etc.) accepted by the URI route
changing the return values on error conditions
changing the data structure for a resource at a given URI

jlongever · 2016-02-19T19:25:40Z

test this please

houndci-bot · 2016-02-19T19:27:46Z

lib/api/2.0/tags.js

+var controller = injector.get('Http.Services.Swagger').controller;
+var nodes = injector.get('Http.Services.Api.Nodes');
+var tags = injector.get('Http.Services.Api.Tags');
+var _ = injector.get('_');


Redefinition of '_'.

JenkinsRHD · 2016-02-19T20:04:55Z

*** BUILD #416 ***
Test Name: Http.Api.Tags "before all" hook: start HTTP server
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
    at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
    at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
    at spec/lib/api/1.1/tags-spec.js:41:19
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

Test Name: Http.Api.Tags "after all" hook: stop HTTP server
Error Details: Cannot read property 'find' of undefined
Stack Trace: TypeError: Cannot read property 'find' of undefined
    at spec/lib/api/1.1/tags-spec.js:62:27
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

JenkinsRHD · 2016-02-19T20:23:30Z

*** BUILD #417 ***
Test Name: Http.Api.Config v2.0 "before all" hook: start HTTP server
Error Details: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.
Stack Trace: Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

Test Name: Http.Api.Tags "before all" hook: start HTTP server
Error Details: Should wrap property of object
Stack Trace: TypeError: Should wrap property of object
    at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:67:23)
    at Object.stub (node_modules/sinon/lib/sinon/stub.js:61:26)
    at spec/lib/api/1.1/tags-spec.js:41:19
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

Test Name: Http.Api.Tags "after all" hook: stop HTTP server
Error Details: Cannot read property 'find' of undefined
Stack Trace: TypeError: Cannot read property 'find' of undefined
    at spec/lib/api/1.1/tags-spec.js:62:27
    at b (domain.js:183:18)
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

WangWinson · 2016-02-22T02:52:14Z

Thanks @jlongever
👍

jlongever · 2016-02-22T14:13:39Z

@zyoung51 assuming unit-test failures are due to on-core dependency: RackHD/on-core#88.

+1 when conflicts resolved.

- Add 'tags' to nodes to identify groups of nodes by arbitrary tag names - Add 1.1 and 2.0 paths for new /nodes and /tags routes.

jlongever · 2016-02-23T18:59:17Z

test this please

jlongever · 2016-02-26T16:18:39Z

Closing this PR, new PR here resolving merge conflicts #154

houndci-bot reviewed Feb 18, 2016
View reviewed changes

anhou reviewed Feb 18, 2016
View reviewed changes

houndci-bot reviewed Feb 19, 2016
View reviewed changes

zyoung51 force-pushed the feature/node-tagging branch from c91e39d to a751e01 Compare February 19, 2016 19:34

Zack Young added 2 commits February 23, 2016 06:00

Node Tagging

22cdfc8

- Add 'tags' to nodes to identify groups of nodes by arbitrary tag names - Add 1.1 and 2.0 paths for new /nodes and /tags routes.

Address review comments

189e3f7

zyoung51 force-pushed the feature/node-tagging branch from a751e01 to 189e3f7 Compare February 23, 2016 14:32

jlongever mentioned this pull request Feb 26, 2016

Feature/node tagging #154

Merged

jlongever closed this Feb 26, 2016

Node Tagging #135

Node Tagging #135

Uh oh!

Conversation

zyoung51 commented Feb 18, 2016

Uh oh!

houndci-bot Feb 18, 2016

Choose a reason for hiding this comment

Uh oh!

houndci-bot Feb 18, 2016

Choose a reason for hiding this comment

Uh oh!

houndci-bot Feb 18, 2016

Choose a reason for hiding this comment

Uh oh!

houndci-bot Feb 18, 2016

Choose a reason for hiding this comment

Uh oh!

zyoung51 commented Feb 18, 2016

Uh oh!

JenkinsRHD commented Feb 18, 2016

Uh oh!

anhou Feb 18, 2016

Choose a reason for hiding this comment

Uh oh!

WangWinson commented Feb 19, 2016

Uh oh!

anhou commented Feb 19, 2016

Uh oh!

jlongever commented Feb 19, 2016

Uh oh!

JenkinsRHD commented Feb 19, 2016

Uh oh!

zyoung51 commented Feb 19, 2016

Uh oh!

jlongever commented Feb 19, 2016

Uh oh!

jlongever commented Feb 19, 2016

Uh oh!

houndci-bot Feb 19, 2016

Choose a reason for hiding this comment

Uh oh!

JenkinsRHD commented Feb 19, 2016

Uh oh!

JenkinsRHD commented Feb 19, 2016

Uh oh!

WangWinson commented Feb 22, 2016

Uh oh!

jlongever commented Feb 22, 2016

Uh oh!

jlongever commented Feb 23, 2016

Uh oh!

jlongever commented Feb 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants