-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsp/stm32] add the bsp of robomaster dev board C #4837
Conversation
请使用这个扫描一下https://github.com/mysterywolf/formatting 就不会报错了 |
好的,我用这个改一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是应该把这个bsp加入到CI机器人检查中? 貌似没有加入. @Guozhanxin
可以啊 |
CFLAGS += ' -O2' | ||
|
||
CXXFLAGS = CFLAGS | ||
CFLAGS += ' -std=c99' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个要去掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是只去除92行吧
在 STM32系列BSP制作教程.md 中的 IDE 配置章节提到要使能 C99 支持,和这里有关系吗?
其他没啥问题,很棒 |
你好麻烦请随便发点什么到 meco@rt-thread.org,我拉你一下微信群,我们讨论一下之前的PWM问题。 |
拉取/合并请求描述:(PR description)
[
增加对 Robomaster 开发板 C 型的支持
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up