Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp/stm32] add the bsp of robomaster dev board C #4837

Merged
merged 8 commits into from
Jul 5, 2021

Conversation

icrazt
Copy link
Contributor

@icrazt icrazt commented Jul 1, 2021

拉取/合并请求描述:(PR description)

[

增加对 Robomaster 开发板 C 型的支持

  • 这是第一阶段提交:已开启串口驱动和 GPIO 驱动,能运行 FinSH 控制台
  • 完成 MDK5 、IAR 和 GCC 编译器支持,已测试的生成类型:mdk5/iar/cmake

]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

请使用这个扫描一下https://github.com/mysterywolf/formatting 就不会报错了

@icrazt
Copy link
Contributor Author

icrazt commented Jul 1, 2021

请使用这个扫描一下https://github.com/mysterywolf/formatting 就不会报错了

好的,我用这个改一下

Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是应该把这个bsp加入到CI机器人检查中? 貌似没有加入. @Guozhanxin

@Guozhanxin
Copy link
Member

是不是应该把这个bsp加入到CI机器人检查中? 貌似没有加入. @Guozhanxin

可以啊

CFLAGS += ' -O2'

CXXFLAGS = CFLAGS
CFLAGS += ' -std=c99'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个要去掉

Copy link
Contributor Author

@icrazt icrazt Jul 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是只去除92行吧
STM32系列BSP制作教程.md 中的 IDE 配置章节提到要使能 C99 支持,和这里有关系吗?

@Guozhanxin
Copy link
Member

@Guozhanxin
Copy link
Member

其他没啥问题,很棒

@Guozhanxin Guozhanxin added the +1 Agree +1 label Jul 5, 2021
@Guozhanxin Guozhanxin merged commit b3fa063 into RT-Thread:master Jul 5, 2021
@mysterywolf
Copy link
Member

你好麻烦请随便发点什么到 meco@rt-thread.org,我拉你一下微信群,我们讨论一下之前的PWM问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants