Pulls/mac support #248
Merged
Pulls/mac support #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take two because last time I accidentally swapped the XCode project files
You need to use `xattr -cr path/to/v3-mac.zip` or `xattr -cr path/to/RSDKv3.app` for this to work
Mefiresu
reviewed
Sep 9, 2024
.github/workflows/build.yml
Outdated
Comment on lines
169
to
172
| - name: Zip the app ourselves (Important step to retain symlinks) | ||
| run: | | ||
| cd ./build/Applications/ | ||
| zip -r RSDKv3.zip ./RSDKv3.app/ |
There was a problem hiding this comment.
Since xattr -cr RSDKv3.app is required for anyone to run the decomp on their machine, you could add a simple README in the zip file:
echo 'Install the .app file and run "xattr -cr /Applications/RSDKv3.app" in the terminal' > README.txtAnd perhaps add this instruction somewhere in the build guide?
There was a problem hiding this comment.
Do you think this is good?
cd ./build/Applications/
echo 'From this folder, run `xattr -cr RSDKv3.app` in Terminal to allow MacOS to open it.' > README.txt
zip -r RSDKv3.zip .
Because I included the readme in the zip, it extracts the folder RSDKv3 and it has the readme and app inside.
There was a problem hiding this comment.
Yes that's perfect, only missing this info in the build guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#246 #247
You know the drill.