Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Mac XCode Projects Take 2 #247

Closed
wants to merge 7 commits into from

Conversation

KirbyKid256
Copy link
Contributor

So last time I accidentally broke it by swapping the xcode projects for the Dependencies and the Engine. This time, I suffered an ungodly amount of time figuring out how to apply compiler flags and getting the autobuild to work, also after messing up my forks having to redo everything.

This pull request the RSDKv3 mac builds up to speed with the latest GitHub commit. This includes updated icons, making sure the build doesn't crash for me, and being able to easily building signed frameworks for Ogg, Vorbis, and Theora. The new README also includes how to use and modify the CXX Flags.

The majority of the code is from @Sappharad's fork, although I did get permission beforehand to use it to do a pull request. I I have edited and removed some of the changes from the fork.

Please test this on Windows before you pull because while not much should have changed, I can't test it on Windows because I don't know how to compile it for Windows while on a Mac.

As for the autobuild, if you download the v3-mac.zip it will say that the app is broken. That is wrong. To be able to use it, run xattr -cr RSDKv3.app assuming your current directory is where the app is. Or just type xattr -cr and drop the app into the Terminal.

Take two because last time I accidentally swapped the XCode project files
Yeah I figured that was what was gonna get me. Try again
How hard do I need to specify the `\`
@KirbyKid256
Copy link
Contributor Author

Was tired and hungry last night so I forgot to mention this resolves #221

@KirbyKid256
Copy link
Contributor Author

KirbyKid256 commented Sep 6, 2024

Hold on a sec the fullscreen doesn't look right
Screenshot 2024-09-06 at 8 18 29 AM
I'll probably tackle this in a different pull request

@Mefiresu
Copy link
Member

Mefiresu commented Sep 9, 2024

As for the autobuild, if you download the v3-mac.zip it will say that the app is broken. That is wrong. To be able to use it, run xattr -cr RSDKv3.app assuming your current directory is where the app is. Or just type xattr -cr and drop the app into the Terminal.

Google says it's because the app hasn't been signed.
As code signing can be a bit difficult to set up correctly, can running xattr -cr RSDKv3.app after the building step fix the issue?

@KirbyKid256
Copy link
Contributor Author

Google says it's because the app hasn't been signed. As code signing can be a bit difficult to set up correctly, can running xattr -cr RSDKv3.app after the building step fix the issue?

Well if you build it yourself then there's no need to use that command. And if you were to upload it to for example Google Drive and redownload it, all you will need to do is hold Ctrl, click the app, and select open to allow the option to open anyways. However, for some reason if you download it via the GitHub actions autobuild, you need to use the xattr -cr command on the downloaded zip or app itself in order to open it, otherwise it will say it's damaged. I could try to see if I can apply the command through the autobuild after it zipped to see if it sticks but otherwise you'll have to do the command yourself.

If this doesn't work I'll just revert it
@KirbyKid256
Copy link
Contributor Author

Nope, I don't think it does

@Sappharad
Copy link

Sappharad commented Sep 9, 2024

The xattr command is just telling your local machine to trust the unsigned app. It won’t affect any other machines.

The only solution that doesn’t require workarounds is actual code signing, but I don’t think you’re going to find a developer who wants to put their paid signing keys on a public GitHub build bot.

The right-click open trick is also being removed in macOS 15 that comes out next week. The only options for working builds would be getting a dev to sign them for you, building it yourself because it signs for the machine you build on, or the getting an unsigned build and running the xattr command to set the trusted attribute.

@Mefiresu
Copy link
Member

Mefiresu commented Sep 9, 2024

The only solution that doesn’t require workarounds is actual code signing, but I don’t think you’re going to find a developer who wants to put their paid signing keys on a public GitHub build bot.

I was wondering if we could use self signed certificates for this as well, which imo would be good enough for such a project. Do you know if this is possible on macOS?

@Sappharad
Copy link

The only solution that doesn’t require workarounds is actual code signing, but I don’t think you’re going to find a developer who wants to put their paid signing keys on a public GitHub build bot.

I was wondering if we could use self signed certificates for this as well, which imo would be good enough for such a project. Do you know if this is possible on macOS?

Self signed certs are basically what you’re using when you build locally without a bot. No, on a buildbot that is going to be equivalent to not being signed at all since the cert isn’t going to be trusted by the end users. And the certs on macOS come from Apple, it’s not like windows where they can come from any certificate authority trusted at the OS level.
There’s not really a good option other than getting it added to a package manager so a user could run a command and get their own build.

@KirbyKid256 KirbyKid256 deleted the branch RSDKModding:master September 9, 2024 18:17
@KirbyKid256 KirbyKid256 closed this Sep 9, 2024
@KirbyKid256 KirbyKid256 deleted the master branch September 9, 2024 18:17
@KirbyKid256
Copy link
Contributor Author

... Are you serious?

@KirbyKid256 KirbyKid256 mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants