Stop walls from coming back from the dead - #5453
Merged
cwisniew merged 4 commits intoMay 21, 2025
Merged
Conversation
When the selected wall is deleted, it is always nulled out now, and that deletion is consistently broadcasted to other clients as well. The `DrawingWallToolMode` also only sets the selected wall when it is activated, rather than setting it while the previous tool is still active.
This responsibility is better placed in the Wall topology tool itself. With this change, the control panel only has to manage the immutable `Wall.Data` rather than an entire `Wall`. This also cleans the panel up a bit since it now longer has to keep track of the current zone either.
Most modes will sync any wall updates when they happen. But the `DrawingWallTopologyTool` uses a temporary wall that is not part of the zone yet, so changes to that temporary wall should not be synced.
These methods in `Wall` and `WallTopologyTool` barely helped save keystrokes, and they somewhat obscure what is actually going on.
cwisniew
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes issue with #5271
Description of the Change
When using the Wall tool, the selected wall is now handled more consistently. There a few facets to this:
Wall.Dataas its model, rather than a complete and mutableWall.DrawingWallToolMode, the selected wall is only temporary, so changes to it are not synced.Beyond that, I've cleaned up a bunch of helper methods that hardly saved anything, and I found they actually obscured what was happening.
Possible Drawbacks
Should be none
Documentation Notes
N/A
Release Notes
N/A
This change is