cellPad, cellVdec and sys_process fixes #5719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Mar 13, 2019
•
elad335
commented
- Fix passing ASSIGN_CHANGES flag in cellPadGetInfor since its not supported by this function.
- Minor optimizations in pad_thread, use raw ptr when possible and replace std::vector with std::array in m_pads container.
- Fix segfault when reading stack memory in the debugger.
- Remove handle in cellVdecClose.
- Fix page fault range check. (old bug)
- Allow recieving frame information only once in cellVdecGetPicItem, fixes Toy Home. (used to iterate this func infinitely)
- Fix Emulator crash after SPU access violation.
- Fix sys_process_exit2 when waiting for SPUs at av handler to terminate. Fixes Regression: Yakuza 1&2 HD EDITION [BLJM60471] (#5244) #5713
- Improve vblank timing, fixing potential stutter and micro frame rate spikes.
- Fix timer (sys_timer) state after event queue destruction. testcase
- Implemented sys_vm_append/return_memory, improved sys_vm error checking.
elad335
force-pushed
the
wip-pad
branch
3 times, most recently
from
7c5c1ac
to
ea65e8c
Compare
|
This also fixed Siren Blood Curse halt with hle cellvdec. |
elad335
force-pushed
the
wip-pad
branch
2 times, most recently
from
245af78
to
8a83d16
Compare
|
any update when it will merge to the master thanks again elad : ) |
elad335
force-pushed
the
wip-pad
branch
5 times, most recently
from
4d2ba2c
to
cfcf3be
Compare
elad335
force-pushed
the
wip-pad
branch
6 times, most recently
from
a170b56
to
63a9472
Compare
|
Doom 3 [NPUB30889] (nothing ->playable) |
elad335
force-pushed
the
wip-pad
branch
2 times, most recently
from
9b82596
to
79ef5ab
Compare
Nekotekina
reviewed
Mar 28, 2019
elad335
force-pushed
the
wip-pad
branch
6 times, most recently
from
a21c55b
to
a48d3a4
Compare
the debugger uses super ptr which was unmapped for stack.
- Dont bother with shared_ptr since all pad_t management is going under the pad mutex. - Change m_pads type into std::array since its size is known
ASSIGN_CHANGES flag is not returned in this func.
Those are the initial argument checks done by the firmware
Range end check was bugged (always true), also rewrite it so vm::get would be called only once
Remove context switch, replace it with host yield() for giving some cpu time for SPUs ans RSX
* Hw tests show state is unaffected by external destruction of the event queue * Minor race regarding state check fixed (can result in an undestroyable state)
Nekotekina
approved these changes
Mar 31, 2019
|
Locking to prevent the usual batch of unrelated comments |
|
@elad335 I just found out that this fixed input in Blazing Angels 2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.