Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package installation #13329

Merged
merged 5 commits into from
Feb 5, 2023
Merged

Fix package installation #13329

merged 5 commits into from
Feb 5, 2023

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Jan 31, 2023

  • Improves logging during package installations
  • Fix package installation exit condition after error occured
  • Don't use u8path for filesystem path

TODO: check utf8 path

The issue is the u8path resolve of
image
which returns an empty std::filesystem::path which in turn is an invalid argument for std::filesystem::weakly_canonical.
Maybe it should be escaped differently or ignored or whatever the ps3 may do.

image

Furthermore, the game tries to install two files with identical name but different cases without the overwrite flag (see issue #13328)

fixes #13327

@MSuih
Copy link
Member

MSuih commented Feb 2, 2023

Tested this by installing a pkg to directory which has Üñıcödë in the path.

Master: Crashes entire emulator when trying to install the file.
This PR: PKG installs fine.

There seems to be debug information printed on error level that should be cleaned up:

E PKG: Entry 0x80000101: USRDIR/EBOOT.BIN (pad=0x0)
E PKG: Entry 0x80000101: USRDIR/RDR2.self (pad=0x0)
E PKG: Entry 0x80000101: USRDIR/EBOOT.BIN (pad=0x0)
E PKG: Entry 0x80000101: USRDIR/RDR2.self (pad=0x0)

@Megamouse
Copy link
Contributor Author

Changed it to be a bit more descriptive. also changed log level to TODO:

U PKG TODO: Entry with unknown type or padding: type=0x80000101, pad=0x0, name='USRDIR/EBOOT.BIN'
! PKG: Entry: type=0x80000003, name='USRDIR/boot.ini'
...

@Rex000
Copy link

Rex000 commented Feb 5, 2023

This isn't merged yet?

@Megamouse Megamouse merged commit 13ef4c1 into RPCS3:master Feb 5, 2023
@Megamouse Megamouse deleted the faighasf branch February 6, 2023 19:04
@2banditos
Copy link

Tested this by installing a pkg to directory which has Üñıcödë in the path.

Master: Crashes entire emulator when trying to install the file. This PR: PKG installs fine.

There seems to be debug information printed on error level that should be cleaned up:

E PKG: Entry 0x80000101: USRDIR/EBOOT.BIN (pad=0x0)
E PKG: Entry 0x80000101: USRDIR/RDR2.self (pad=0x0)
E PKG: Entry 0x80000101: USRDIR/EBOOT.BIN (pad=0x0)
E PKG: Entry 0x80000101: USRDIR/RDR2.self (pad=0x0)

I have the same error trying to install the patch in Fight Night Champion! Any solution ?
Entry 0x80000101: USRDIR/EBOOT.BIN (pad=0x0)

@2banditos
Copy link

@Megamouse Could you help us installing the Fight Night Champion patch?

Hier ist der Link zu unserer Discord Gruppe:
https://discord.gg/RjZz7R34
Wäre spitze wenn du uns dabei unterstützen könntest!

LG 2banditos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Raystorm HD [NPJB00034] - Crash during installation
4 participants