dist: tools: revert "dist: cppcheck: switch back to 8 jobs" #6963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec97a94. (The commit seems to cause trouble. Furthermore, there's no reference to either the issue or how it was solved in the original commit message).
kaspar030
added
Type: bug
kaspar030
added
the
CI: ready for build
smlng
approved these changes
Apr 25, 2017
|
the cite is for option |
So now we're enabling that check again. But I don't think that'll hurt. :) |
|
This doesn't change any code, and murdock2 succesfully ran cppcheck. Does anyone feel inclined to merge? |
|
Murdock2 and Murdock have the same cppcheck version, so I think its fine to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ec97a94.
The commit seems to cause exit with error code != 0, even if there's no error, on cppcheck 1.72, which is our current CI version.
Furthermore, there's no reference to either the issue or how it was resolved in the original commit message.