Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys: crypto: Remove 3DES crypto #6960

Merged
merged 1 commit into from
Apr 26, 2017
Merged

sys: crypto: Remove 3DES crypto #6960

merged 1 commit into from
Apr 26, 2017

Conversation

emmanuelsearch
Copy link
Member

@emmanuelsearch emmanuelsearch commented Apr 25, 2017 •
edited
Loading

A few days ago at a research seminar on RIOT, a cryptographer complained that we "still" support 3DES, which is considered legacy.
Googling around, this seems true.

Hence this PR, which removes 3DES support.
Are there contrary opinions on this?
I plan to also email devel@ and user@ to pre-warn of this pending removal.

@emmanuelsearch emmanuelsearch added the Area: crypto Area: Cryptographic libraries label Apr 25, 2017
@emmanuelsearch emmanuelsearch added this to the Release 2017.04 milestone Apr 25, 2017
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 25, 2017
@kaspar030
Copy link
Contributor

+1

@kaspar030
Copy link
Contributor

please squash

@emmanuelsearch
Copy link
Member Author

cppcheck complains weirdly that:

$ ./dist/tools/externc/check.sh
file does not have a C++ compatible header: 'pkg/nordic_softdevice_ble/src/ble-mac.h'

@kaspar030 kaspar030 mentioned this pull request Apr 25, 2017
Merged
miri64
miri64 requested changes Apr 25, 2017
View reviewed changes
dist/tools/cppcheck/check.sh Outdated
@@ -53,6 +53,7 @@ if [ -z "${FILES}" ]; then
exit
fi

cppcheck --std=c99 --enable=style --force --error-exitcode=2 --quiet -j 8 \
# TODO: switch back to 8 jobs when/if cppcheck issue is resolved
cppcheck --std=c99 --enable=style --force --error-exitcode=2 --quiet -j 1 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix provided in #6963 ;-)

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 25, 2017
@miri64 miri64 merged commit 006b12e into RIOT-OS:master Apr 26, 2017
@PeterKietzmann PeterKietzmann mentioned this pull request Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@haukepetersen haukepetersen

@kaspar030 kaspar030

Labels
Area: crypto Area: Cryptographic libraries CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2017.07
Development

Successfully merging this pull request may close these issues.
4 participants
@emmanuelsearch @kaspar030 @miri64 @haukepetersen