Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/cc2538: clear only the latched UART interrupt flags #2652

Merged
merged 2 commits into from
Mar 8, 2016
Merged

cpu/cc2538: clear only the latched UART interrupt flags #2652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f05a95
cpu/cc2538: clear only the latched UART interrupt flags
hexluthor Mar 19, 2015
7058797
cpu/cc2538: use the MCU's default UART FIFO interrupt levels
hexluthor Mar 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions cpu/cc2538/periph/uart.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,9 @@ void UART_0_ISR(void)
{
uint_fast16_t mis;

/* Store the current MIS and clear all flags early, except the RTM flag.
* This will clear itself when we read out the entire FIFO contents */
/* Latch the Masked Interrupt Status and clear any active flags */
mis = UART_0_DEV->cc2538_uart_mis.MIS;

UART_0_DEV->ICR = 0x0000FFBF;
UART_0_DEV->ICR = mis;

while (UART_0_DEV->cc2538_uart_fr.FRbits.RXFE == 0) {
uart_config[0].rx_cb(uart_config[0].arg, UART_0_DEV->DR);
Expand All @@ -137,11 +135,9 @@ void UART_1_ISR(void)
{
uint_fast16_t mis;

/* Store the current MIS and clear all flags early, except the RTM flag.
* This will clear itself when we read out the entire FIFO contents */
mis = UART_1_DEV->MIS;

UART_1_DEV->ICR = 0x0000FFBF;
/* Latch the Masked Interrupt Status and clear any active flags */
mis = UART_1_DEV->cc2538_uart_mis.MIS;
UART_1_DEV->ICR = mis;

while (UART_1_DEV->FRbits.RXFE == 0) {
uart_config[1].rx_cb(uart_config[1].arg, UART_1_DEV->DR);
Expand Down Expand Up @@ -296,8 +292,8 @@ static int init_base(uart_t uart, uint32_t baudrate)
u->cc2538_uart_im.IMbits.FEIM = 1; /**< UART framing error interrupt mask */

/* Set FIFO interrupt levels: */
u->cc2538_uart_ifls.IFLSbits.RXIFLSEL = FIFO_LEVEL_1_8TH;
u->cc2538_uart_ifls.IFLSbits.TXIFLSEL = FIFO_LEVEL_4_8TH;
u->cc2538_uart_ifls.IFLSbits.RXIFLSEL = FIFO_LEVEL_4_8TH; /**< MCU default */
u->cc2538_uart_ifls.IFLSbits.TXIFLSEL = FIFO_LEVEL_4_8TH; /**< MCU default */

u->cc2538_uart_ctl.CTLbits.RXE = 1;
u->cc2538_uart_ctl.CTLbits.TXE = 1;
Expand Down