Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/cc2538: clear only the latched UART interrupt flags #2652

Merged
merged 2 commits into from
Mar 8, 2016
Merged

cpu/cc2538: clear only the latched UART interrupt flags #2652

merged 2 commits into from
Mar 8, 2016

Conversation

hexluthor
Copy link
Contributor

Observed incoming bytes lingering in the receive FIFO indefinitely without generating an interrupt. This patch fixes the problem.

@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Mar 19, 2015
@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@PeterKietzmann
Copy link
Member

Travis is happy now. Has anyone the hardware to test?

@OlegHahm
Copy link
Member

OlegHahm commented May 9, 2015

@haukepetersen, can you test with the OpenMote?

@haukepetersen
Copy link
Contributor

oh, sorry, overlooked this one. Will test Thursday when I am back in the office...

@OlegHahm
Copy link
Member

.

@haukepetersen
Copy link
Contributor

damn, forgot about this, will try shortly.

@OlegHahm
Copy link
Member

🙌

@OlegHahm OlegHahm modified the milestone: Release NEXT MAJOR Sep 2, 2015
@OlegHahm OlegHahm modified the milestone: Release 2015.12 Nov 28, 2015
@OlegHahm OlegHahm modified the milestone: Release 2016.03 Dec 8, 2015
@OlegHahm
Copy link
Member

damn, forgot about this, will try shortly.

So? ;-)

@OlegHahm OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Feb 29, 2016
@OlegHahm OlegHahm assigned kYc0o and unassigned haukepetersen Mar 1, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Mar 1, 2016

Any news here?

@kYc0o
Copy link
Contributor

kYc0o commented Mar 7, 2016

What about merging this, too ;)

@hexluthor
Copy link
Contributor Author

Rebased onto master.

@kYc0o
Copy link
Contributor

kYc0o commented Mar 7, 2016

maybe another rebase is needed or something is wrong since I'm having this problem:

snake-2:default facosta$ make flash
Warning: no PORT set!
Building application "default" for "cc2538dk" with MCU "cc2538".

"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/boards/cc2538dk
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/core
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/cpu/cc2538
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/cpu/cc2538/periph
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/cpu/cortexm_common
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/drivers
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/drivers/saul
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/auto_init
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/auto_init/saul
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/fmt
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/newlib
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/phydat
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/ps
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/saul_reg
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/shell
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/shell/commands
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/tsrb
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT/sys/uart_stdio
   text    data     bss     dec     hex filename
  12380     164    2620   15164    3b3c /Users/facosta/git/RIOT/examples/default/bin/cc2538dk/default.elf
python /Users/facosta/git/RIOT/dist/tools/cc2538-bsl/cc2538-bsl.py -p "" -e -w -v /Users/facosta/git/RIOT/examples/default/bin/cc2538dk/default.bin
ERROR: [Errno 2] could not open port : [Errno 2] No such file or directory: ''
make: *** [flash] Error 1

related to this merge #4877

@kYc0o
Copy link
Contributor

kYc0o commented Mar 7, 2016

Oh, my fault, #4877 does not takes into account PORT_DARWIN so my mac is complaining...

@hexluthor
Copy link
Contributor Author

@kYc0o, #4877 could use some more refinement. What device name(s) does your cc2538dk enumerate as under OSX?

@kYc0o
Copy link
Contributor

kYc0o commented Mar 7, 2016

Actually the problem is that for cc2538dk PORT_DARWIN is defined nowhere, so PORT is pointing to nowhere too...

I ACK this PR since it's working (flashing with PORT_DARWIN added to the makefile).

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 7, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Mar 8, 2016

Travis and RIOT-CI are OK, will merge

kYc0o added a commit that referenced this pull request Mar 8, 2016
@kYc0o
Merge pull request #2652 from locicontrols/cc2538-uart-mis
afeaea0 
cpu/cc2538: clear only the latched UART interrupt flags
@kYc0o kYc0o merged commit afeaea0 into RIOT-OS:master Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kYc0o kYc0o

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
5 participants
@hexluthor @PeterKietzmann @OlegHahm @haukepetersen @kYc0o