dist/tools/insufficient_memory: always update Makefile.ci #20130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Type: enhancement
maribu
added
the
State: WIP
Previously the `add_insufficient_memory_board.sh` script would only add the tested board to `Makefile.ci` when resource requirements grew, but never remove it when resource requirements got lower. This updates the script to also remove boards from `Makefile.ci` if it is no longer needed. It is also rename (`add` --> `update`) to match the change in behavior.
maribu
force-pushed
the
dist/tools/insufficient_memory/update_insufficient_memory_board.sh
branch
from
8ebbcc8
to
922d8c8
Compare
maribu
removed
the
State: WIP
|
I used this in #19784 for each and every AVR8 boards. If that PR now flies smoothly, it should now work. |
benpicco
approved these changes
Jan 4, 2024
maribu
deleted the
dist/tools/insufficient_memory/update_insufficient_memory_board.sh
branch
|
Thx :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Previously the
add_insufficient_memory_board.shscript would only add the tested board toMakefile.ciwhen resource requirements grew, but never remove it when resource requirements got lower.This updates the script to also remove boards from
Makefile.ciif it is no longer needed. It is also rename (add-->update) to match the change in behavior.Testing procedure
Mess up some
Makefile.cifiles by randomly adding and remove board$BOARD. Run./dist/tools/insufficient_memory/add_insufficient_memory_board.sh $BOARD. TheMakefile.cis should be fixed by adding$BOARDwhere needed, and dropping it where it wasn't needed.Issues/PRs references
None