pkg/nanocbor: Update for fixed nanocbor_skip_simple() #19983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
added
the
Type: bug
Important changes: - Fixed a bug in nanocbor_skip_simple with (b|t)str types
bergzand
force-pushed
the
pr/nanocbor-bump3
branch
from
3bd5600 to
ca81c75
Compare
bergzand
changed the title
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Oct 18, 2023
|
bors merge |
|
@MrKevinWeiss @bergzand does it make sense to backport this? It is a bug fix after all, but I am not sure if the previous bump (#19975) should be included (or is already included in RC1 for that matter...) |
|
Let's add the Bugfixes in while we can |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
See #19988 |
MrKevinWeiss
added
the
Process: needs backport
bors bot
added a commit
that referenced
this pull request
Oct 23, 2023
19988: pkg/nanocbor: Update for fixed nanocbor_skip_simple() [backport 2023.10] r=MrKevinWeiss a=bergzand # backport of #19975 and #19983 ### Contribution description Manually created the backport this time 😢 Includes both #19975 and #19983 to include the nanocbor bug fix for the `nanocbor_skip_simple()` function ### Testing procedure The usual nanocbor test in `tests/pkg/nanocbor` ### Issues/PRs references None Co-authored-by: Koen Zandberg <koen@bergzand.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
@miri64 found a bug in NanoCBOR which is fixed with the latest commit.
Important changes:
Testing procedure
The pkg test should still pass.
Issues/PRs references
None