Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/nanocbor: Bump to latest commit #19975

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

bergzand
Copy link
Member

Contribution description

Not much to see here

Important changes:

  • Add stream-like interface for encoder
  • Separate functions for number of items left in arrays and maps

Testing procedure

The usual test should still work

Issues/PRs references

None

Important changes:
- Add stream-like interface for encoder
- Separate functions for number of items left in arrays and maps
@bergzand bergzand added the Area: pkg Area: External package ports label Oct 13, 2023
@bergzand bergzand requested review from miri64 and benpicco October 13, 2023 13:27
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 13, 2023
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works with the thingy I am working on (and also the tests/pkg/nanocbor tests on native).

@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Oct 13, 2023
@riot-ci
Copy link

riot-ci commented Oct 13, 2023

Murdock results

✔️ PASSED

a250dfe pkg/nanocbor: Bump to latest commit

Success Failures Total Runtime
7937 0 7937 16m:30s

Artifacts

@miri64
Copy link
Member

miri64 commented Oct 13, 2023

bors merge

bors bot added a commit that referenced this pull request Oct 13, 2023
19975: pkg/nanocbor: Bump to latest commit r=miri64 a=bergzand

### Contribution description

Not much to see here

Important changes:
- Add stream-like interface for encoder
- Separate functions for number of items left in arrays and maps

### Testing procedure

The usual test should still work

### Issues/PRs references

None

Co-authored-by: Koen Zandberg <koen@bergzand.net>
@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

Build failed:

  • static-tests

@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 16, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 910e0e2 into RIOT-OS:master Oct 16, 2023
27 checks passed
bors bot added a commit that referenced this pull request Oct 23, 2023
19988: pkg/nanocbor: Update for fixed nanocbor_skip_simple() [backport 2023.10] r=MrKevinWeiss a=bergzand

# backport of #19975 and #19983

### Contribution description

Manually created the backport this time 😢 

Includes both #19975 and #19983 to include the nanocbor bug fix for the `nanocbor_skip_simple()` function

### Testing procedure

The usual nanocbor test in `tests/pkg/nanocbor`

### Issues/PRs references

None

Co-authored-by: Koen Zandberg <koen@bergzand.net>
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants