-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/gnrc_dhcpv6_client: add script to check if $IFACE exists #16797
tests/gnrc_dhcpv6_client: add script to check if $IFACE exists #16797
Conversation
996b9b4
to
11ce942
Compare
As pointed out by @fjmolinas in #16796 (comment), the export is not necessary. So I removed that dependency with the latest rebase and adopted the Makefile to expose |
PORT may be checked for existence as well - in native case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be rebased and squashed -since its dependencies are merged.
Maybe the wording in the failure message can be changed as well:
It is set by default. |
i meant check if the interface the is named by PORT is exiting (since it might be a non exiting tap interface with native) but it is also the case the such a checkscript is not able to test for every misconfiguration (maybe both exist but aren't conected) |
The native instance will fail to start if it can't be used as a TAP interface or if it isn't initialized. Adding yet another check for that is IMHO really not necessary. If you don't know how to use |
ef1eaf9
to
845d589
Compare
Rebased and squashed latest suggestion |
somehow IFACE sems to not be set
finishes successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a comment would be nice for a future reader of this Makefile
I tested: in between these tests please squash |
9a427a1
to
73d5997
Compare
Done. I also removed the now orphaned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
🥳
🎉
Contribution description
Adds a checker script if the required interface for
tests/gnrc_dhcpv6_client
exists.Testing procedure
Run
tests/gnrc_dhcpv6_client
with and without a TAP interfaceIssues/PRs references
Depends on #16795 for the config check to work
and #16796 for the(see #16797 (comment)).$IFACE
export