Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: add capability to check config for test-with-config #16795

Merged

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Sep 1, 2021

Contribution description

This adds another dependency for test-with-config that uses (optional) check-config scripts within the tests-with-config directory to check if the config required for the test is available. If the config is not available, the make test-with-config target will fail with an appropriate error message.

Testing procedure

I will provide a config checker for tests/gnrc_dhcpv6_client as a follow-up (#16797). With that, this PR will be testable.

Issues/PRs references

None

@miri64 miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Sep 1, 2021
@miri64 miri64 requested review from aabadie and fjmolinas September 1, 2021 14:51
@github-actions github-actions bot added Area: build system Area: Build system Area: tests Area: tests and testing framework labels Sep 1, 2021
@miri64
Copy link
Member Author

miri64 commented Sep 3, 2021

Took your suggestions and added my own spin to it (and also fixed some of the wording ;-))

Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also long and difficult to read -> comment to explain

@kfessel
Copy link
Contributor

kfessel commented Sep 3, 2021

I am ok with your spin on the comments mine where mostly for inspiration.

I tested this with the check-config provided in PR #16797 failing and succeeding as expected ✔️

these PRs have a small problem of hen and egg

this should be squashed and
checked by murdock and tests should be run

@miri64
Copy link
Member Author

miri64 commented Sep 3, 2021

checked by murdock and tests should be run

test-with-config tests are not run by murdock anyways...

@miri64 miri64 force-pushed the make-tests-with-config/feat/config-check branch from 8e91cb5 to 0b23060 Compare September 3, 2021 14:41
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 3, 2021
@miri64
Copy link
Member Author

miri64 commented Sep 3, 2021

these PRs have a small problem of hen and egg

Not really: One introduces the feature and one uses it for one specific test. There is no cyclic dependency between them, so no hen-egg-problem :-).

@kfessel
Copy link
Contributor

kfessel commented Sep 3, 2021

these PRs have a small problem of hen and egg

Not really: One introduces the feature and one uses it for one specific test. There is no cyclic dependency between them, so no hen-egg-problem :-).

i got into the hen and egg while testing since i did not want to use another pr to test this of cause there is no circular dependancy graph

test $$t = "empty" && break; \
$$t || \
(echo "System configuration for" \
"tests is not available, check $${t#$${RIOTBASE}/} failed." \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tests is not available, check $${t#$${RIOTBASE}/} failed." \
"tests is not available, check $${t#$${RIOTBASE}/}." \

Copy link
Contributor

@kfessel kfessel Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" check tests/gnrc_dhcpv6_client/tests-with-config/check-config.sh failed. "
i read the "check" a a verb and it sounded wrong to me, but if check and the filename are one noun it sounds correct

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks to me like a part of the sentence is missing...

Copy link
Contributor

@kfessel kfessel Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was just citing the part after the , but as said i was reading it kinda wrong

@kfessel kfessel added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Sep 3, 2021
Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge.

@miri64 miri64 merged commit 473ab2f into RIOT-OS:master Sep 3, 2021
@miri64 miri64 deleted the make-tests-with-config/feat/config-check branch September 3, 2021 22:15
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants