Skip to content

Remove script tags in R v4.2.x help pages #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renkun-ken merged 2 commits into from
Dec 4, 2022
Merged

Remove script tags in R v4.2.x help pages #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c3ca7
Remove script tags in R v4.2.2 help pages
ManuelHentschel Dec 2, 2022
e8a4e89
Tweak css selector
ManuelHentschel Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion html/help/script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ window.document.body.onload = () => {
// notify vscode when code is clicked:
if(document.body.classList.contains('preClickable')){
const codeElements = document.getElementsByTagName('pre');
console.log(codeElements);
for(let i=0; i<codeElements.length; i++){
const el = codeElements[i];
el.onclick = (me: MouseEvent) => {
Expand Down
8 changes: 7 additions & 1 deletion src/helpViewer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,13 @@ function pimpMyHelp(helpFile: HelpFile): HelpFile {
if(helpFile.isHtml){
// Remove style elements specified in the html itself (replaced with custom CSS)
$('head style').remove();


// strip tags: <code class="language-R">...
const preCodes = $('pre>code');
preCodes.each((_, pc) => {
$(pc).replaceWith($(pc).html() || '');
});

// Split code examples at empty lines:
const codeClickConfig = config().get<CodeClickConfig>('helpPanel.clickCodeExamples');
const isEnabled = CODE_CLICKS.some(k => codeClickConfig?.[k] !== 'Ignore');
Expand Down