Skip to content

Remove script tags in R v4.2.x help pages#1268

Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:syntaxHL
Dec 4, 2022
Merged

Remove script tags in R v4.2.x help pages#1268
renkun-ken merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:syntaxHL

Conversation

@ManuelHentschel
Copy link
Member

Remove script tags introduced in R 4.2.x. These are used for syntax highlighting in the normal html help, but mess a bit with the formatting of the vscode help view.

@renkun-ken
Copy link
Member

Would you like to put a screenshot to demonstrate the difference?

@ManuelHentschel
Copy link
Member Author

Sure!

Before:
image

After:
image

@eitsupi
Copy link
Contributor

eitsupi commented Dec 2, 2022

Maybe #1152 ?

@ManuelHentschel
Copy link
Member Author

Maybe #1152 ?

That looks similar. Does this change fix the problem for you?

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

LGTM

@renkun-ken renkun-ken merged commit a7671ab into REditorSupport:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants