Skip to content

Take out http from link snippet#1085

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
jooyoungseo:link_snippet
Apr 27, 2022
Merged

Take out http from link snippet#1085
renkun-ken merged 1 commit intoREditorSupport:masterfrom
jooyoungseo:link_snippet

Conversation

@jooyoungseo
Copy link
Contributor

@jooyoungseo jooyoungseo commented Apr 26, 2022

What problem did you solve?

similar to #1084: link could be a relative path or even local path. Also https could be used. Thus, do not fix it as http://.

(If you have)Screenshot

(If you do not have screenshot) How can I check this pull request?

In Rmd file, try Insert link snippet.

@jooyoungseo jooyoungseo changed the title Take out http (#1084) Take out http from link snippet Apr 26, 2022
Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit f32c3c7 into REditorSupport:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants