Skip to content

Take out http from Insert image Rmd snippet#1084

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
jooyoungseo:img-snippet
Apr 23, 2022
Merged

Take out http from Insert image Rmd snippet#1084
renkun-ken merged 1 commit intoREditorSupport:masterfrom
jooyoungseo:img-snippet

Conversation

@jooyoungseo
Copy link
Contributor

What problem did you solve?

Currently, Insert image Rmd snippet assumes that the image link should be a remote URL. However, this is overgeneralization because local image can b also used. Thus, I've taken out the http from the snippet.

(If you have)Screenshot

(If you do not have screenshot) How can I check this pull request?

Try using Insert image snippet in any Rmd file.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit 6280d58 into REditorSupport:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants