Skip to content

fix: return 404 for missing build files 🐵 #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmertens merged 2 commits into from
Sep 5, 2025
+9 −0
Merged

fix: return 404 for missing build files 🐵 #7914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afbbd60
fix: return 404 for missing build files 🐵
gioboa Sep 5, 2025
b0084a3
chore: add changeset 🍟
gioboa Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-knives-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/qwik-city': patch
---

FIX: return 404 for missing /build/ files.
4 changes: 4 additions & 0 deletions packages/qwik-city/src/runtime/src/route-matcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ function matchRoutePart(
pathIdx: number,
pathLength: number
): PathParams | null {
if (path.startsWith('/build/')) {
Copy link
Member Author

@gioboa gioboa Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good place to intercept the issue without changing too much.

Copy link
Member Author

@gioboa gioboa Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for dev mode in fact it's already working fine in production.
eg. https://qwik.dev/docs/build/abc.js

Copy link
Contributor

@intellix intellix Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not to take assetsDir into consideration :)

Image

Copy link
Member Author

@gioboa gioboa Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, can you open a PR for that?

return null;
}

let params: PathParams | null = null;
while (routeIdx < routeLength) {
const routeCh = route.charCodeAt(routeIdx++);
Expand Down