fix: return 404 for missing build files 🐵 #7914
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b0084a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gioboa
commented
Sep 5, 2025
| pathIdx: number, | ||
| pathLength: number | ||
| ): PathParams | null { | ||
| if (path.startsWith('/build/')) { |
Member
Author
There was a problem hiding this comment.
This is a good place to intercept the issue without changing too much.
Member
Author
There was a problem hiding this comment.
This is only for dev mode in fact it's already working fine in production.
eg. https://qwik.dev/docs/build/abc.js
Contributor
There was a problem hiding this comment.
This seems not to take assetsDir into consideration :)
Member
Author
There was a problem hiding this comment.
Nice catch, can you open a PR for that?
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7852
With a catch all route, if a file is missing eg.
/build/missing_file.jsthe process is trying to match a route for the path. Right now, even if is doing the wrong logic, is returning 301. With this change we will return 404.What is it?
Description
Checklist
pnpm change