-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete some things, simple type names, misc #643
Merged
Merged
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
cf40d52
complete SharedConstants
supersaiyansubtlety 82ceedd
complete n.m.village
supersaiyansubtlety 31a647b
remove 'registryKey' from simple_type_field_names
supersaiyansubtlety 8b28730
registry work
supersaiyansubtlety a88c6ec
complete n.m.registry.tag, more registry work
supersaiyansubtlety e5ce8c3
explicitly map CommandTreeUpdateS2CPacket consturctor param to work a…
supersaiyansubtlety 3e107f0
complete n.m.registry
supersaiyansubtlety 31f60c0
Add class comments to new simple type names
supersaiyansubtlety cd0714c
map ~97/270 RegsitryKeys affected by their removal from simple type n…
supersaiyansubtlety fe1096c
complete Items with the help of simple type names
supersaiyansubtlety bfce206
half way there! (through RegistryKeys affected by their removal from …
supersaiyansubtlety afe70fb
finished! fixing up RegistryKeys affected by their removal from simpl…
supersaiyansubtlety f09e955
fix typos
supersaiyansubtlety a1a050b
remove FindInvalidSimpleTypeFieldNamesTask stub for separate PR
supersaiyansubtlety 8d5f91f
fixup a few things folling self-review
supersaiyansubtlety 89139e6
make simple_type_field_names an input of insertAutoGeneratedMappings …
supersaiyansubtlety 603d368
fix typo
supersaiyansubtlety 400c73c
drop invalid mappings
supersaiyansubtlety 993bc0f
re-complete ResourceKeyArgument
supersaiyansubtlety a3892d5
rename all GET_BY_ID -> BY_ID
supersaiyansubtlety ecaee57
Merge branch '24w39a' into procrastination
supersaiyansubtlety File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -516,6 +516,7 @@ unicode | |
|
|
||
| // registry | ||
| memoize | ||
| memoized | ||
| unregister | ||
|
|
||
| // javadoc | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,33 @@ | ||
| CLASS net/minecraft/unmapped/C_vtbxyypo net/minecraft/registry/HolderLookup | ||
| METHOD m_cjhuibvn holders ()Ljava/util/stream/Stream; | ||
| METHOD m_cjhuibvn streamHolders ()Ljava/util/stream/Stream; | ||
| METHOD m_pgmbmohw streamTagKeys ()Ljava/util/stream/Stream; | ||
| METHOD m_rpikeuoc streamTags ()Ljava/util/stream/Stream; | ||
| METHOD m_vtchccnr streamElementKeys ()Ljava/util/stream/Stream; | ||
| CLASS C_drwjtlvl RegistryLookup | ||
| METHOD m_cplftviu matchesPredicate (Ljava/util/function/Predicate;)Lnet/minecraft/unmapped/C_vtbxyypo$C_drwjtlvl; | ||
| METHOD m_cplftviu withFilter (Ljava/util/function/Predicate;)Lnet/minecraft/unmapped/C_vtbxyypo$C_drwjtlvl; | ||
| COMMENT @return a view of this lookup with entries filtered by the passed {@code predicate} | ||
| ARG 1 predicate | ||
| METHOD m_kqnidhqe enabledIn (Lnet/minecraft/unmapped/C_czxxrbcp;)Lnet/minecraft/unmapped/C_vtbxyypo$C_drwjtlvl; | ||
| ARG 1 featureFlags | ||
| METHOD m_pjiyqhtq (Lnet/minecraft/unmapped/C_czxxrbcp;Ljava/lang/Object;)Z | ||
| ARG 1 gatedObject | ||
| METHOD m_vhaoljfo getRegistryLifecycle ()Lcom/mojang/serialization/Lifecycle; | ||
| METHOD m_wgqigdhk getKey ()Lnet/minecraft/unmapped/C_xhhleach; | ||
| CLASS C_jyxfuyee Delegate | ||
| METHOD m_smgukdep lookup ()Lnet/minecraft/unmapped/C_vtbxyypo$C_drwjtlvl; | ||
| CLASS C_epoknvca | ||
| METHOD m_siwozrxd (Ljava/util/function/Predicate;Lnet/minecraft/unmapped/C_cjzoxshv$C_rjzpeyec;)Z | ||
| ARG 1 holder | ||
| METHOD m_ysslswxl (Ljava/util/function/Predicate;Lnet/minecraft/unmapped/C_cjzoxshv$C_rjzpeyec;)Z | ||
| ARG 1 holder | ||
| CLASS C_jyxfuyee Delegating | ||
| METHOD m_smgukdep getDelegate ()Lnet/minecraft/unmapped/C_vtbxyypo$C_drwjtlvl; | ||
| CLASS C_etmlgbig Provider | ||
| METHOD m_dnidhibf create (Ljava/util/stream/Stream;)Lnet/minecraft/unmapped/C_vtbxyypo$C_etmlgbig; | ||
| ARG 0 lookups | ||
| METHOD m_pbceiquw streamRegistryKeys ()Ljava/util/stream/Stream; | ||
| METHOD m_hlpdjttt getLifecycle ()Lcom/mojang/serialization/Lifecycle; | ||
| COMMENT @return the {@link com.mojang.serialization.Lifecycle lifecycle} for this provider, | ||
| COMMENT determined by the least-stable lifecycle amongst its {@link #streamLookups lookups} | ||
| METHOD m_pbceiquw streamLookups ()Ljava/util/stream/Stream; | ||
| METHOD m_uwaazyzq createSerializationContext (Lcom/mojang/serialization/DynamicOps;)Lnet/minecraft/unmapped/C_piadqmzm; | ||
| METHOD m_vwprjgpp streamRegistryKeys ()Ljava/util/stream/Stream; | ||
| METHOD m_wwvmnchf (Lnet/minecraft/unmapped/C_vtbxyypo$C_drwjtlvl;)Lnet/minecraft/unmapped/C_vtbxyypo$C_drwjtlvl; | ||
| ARG 0 lookup |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,15 @@ | ||
| CLASS net/minecraft/unmapped/C_nlcdnclu net/minecraft/registry/RegistryCloner | ||
| METHOD m_qklykybk (Ljava/lang/String;)Ljava/lang/IllegalStateException; | ||
| ARG 0 errorMessage | ||
| METHOD m_qycjgtcz (Ljava/lang/String;)Ljava/lang/IllegalStateException; | ||
| ARG 0 errorMessage | ||
| METHOD m_zduexkww clone (Ljava/lang/Object;Lnet/minecraft/unmapped/C_vtbxyypo$C_etmlgbig;Lnet/minecraft/unmapped/C_vtbxyypo$C_etmlgbig;)Ljava/lang/Object; | ||
| ARG 1 value | ||
| ARG 2 subsetLookupProvider | ||
| ARG 3 fullLookupProvider | ||
| CLASS C_bxhpbcyq CloneableRegistries | ||
| FIELD f_naqxvgob registries Ljava/util/Map; | ||
| FIELD f_naqxvgob cloners Ljava/util/Map; | ||
| METHOD m_dtbyqapc with (Lnet/minecraft/unmapped/C_xhhleach;Lcom/mojang/serialization/Codec;)Lnet/minecraft/unmapped/C_nlcdnclu$C_bxhpbcyq; | ||
| ARG 1 registry | ||
| METHOD m_lmwgprcv get (Lnet/minecraft/unmapped/C_xhhleach;)Lnet/minecraft/unmapped/C_nlcdnclu; | ||
| ARG 1 registry |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This... Works for now. I would make an issue once this is merged to do this properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaict a proper fix would require enigma plugins to have a way of listing files they depend on, then enigma would list all files all plugins depend onhadn't found
getServiceProfilesIs that what you mean?
Or something in qmap buildSrc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something in the buildsrc