complete some things, simple type names, misc #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…round proposer conflicts, make simple_type_field_names_path an input of insertAutoGeneratedMappings task, make 'id' simple type name exclusive
supersaiyansubtlety
added
t: new
OroArmor
approved these changes
Sep 24, 2024
Co-authored-by: Eli Orona <eliorona@live.com>
…ames rename IdListUtil#sortArray -> createByIdGetter make enums that use createByIdGetter consistent restore SpawnReason add simple type names for Entity+LivinEntity add stub FindInvalidSimpleTypeFieldNamesTask class map a few other things along the way
…simple type names)
supersaiyansubtlety
added
s: large
| CLASS net/minecraft/unmapped/C_uxzryfxv net/minecraft/server/function/FunctionGetter | ||
| FIELD f_cxzaybvc commandFunctionSet Z | ||
| FIELD f_kkregdwp commandFunction Ljava/util/Optional; | ||
| METHOD m_ashjquub getid ()Lnet/minecraft/unmapped/C_ncpywfca; |
There was a problem hiding this comment.
spell check fail?
supersaiyansubtlety
changed the title
OroArmor
approved these changes
Sep 25, 2024
build.gradle
Outdated
Comment on lines
120
to
126
| final enigmaProfile = file("enigma_profile.json") | ||
|
|
||
| inputs.file( | ||
| new JsonSlurper().parse(enigmaProfile) | ||
| .services.jar_indexer.args.simple_type_field_names_path | ||
| ) | ||
|
|
There was a problem hiding this comment.
This... Works for now. I would make an issue once this is merged to do this properly.
There was a problem hiding this comment.
afaict a proper fix would require enigma plugins to have a way of listing files they depend on, then enigma would list all files all plugins depend on
hadn't found getServiceProfiles
Is that what you mean?
Or something in qmap buildSrc?
ix0rai
requested changes
Sep 30, 2024
There was a problem hiding this comment.
looks fantastic, just a couple things:
- there are quite a few empty mappings here, i think
dropInvalidMappingsshould address that - though the enum refactors are great, I don't agree with the
BY_ID->GET_BY_IDrefactor. i don't see any good reason to add the extra word.
Yeah I'm a bit torn on
I guess "by id" is fine for both. |
ix0rai
approved these changes
Oct 1, 2024
ix0rai
added
final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegistryKeyfrom simple_type_field_names (they're often named after their generic type)RegistryKeys affected by its removal from simple_type_field_names (no lost coverage! [except in unmapped classes])Items(thanks type names for 1000+ settings)IdListUtilIdListUtil::createByIdGetterconsistent