Fix handling long application names in qubes.StartApp service #602
Conversation
Application names longer than 37 chars don't fit in qubesdb name limit for app-dispvm service entry. Switch to using hash of the name, which has a constant length. Encode SHA256 of the name using URL-safe base64 (instead of hex) to save some length. And since those entries are generated automatically, move them out of /qubes-service/ qubesdb tree (into /hash-app-dispvm/), to not interfere with manual entries. Fixes QubesOS/qubes-issues#7421
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025082915-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 72 fixed
Unstable testsPerformance TestsPerformance degradation:15 performance degradations
Remaining performance tests:159 tests
|
Skip it in chroot or a container to not fail the RPM transaction. While RPM says it's "non-crtitical error in the %post scriptlet", it does consider RPM transaction as failed in the end. Interestingly, that happens only on Fedora 43, earlier versions actually do treat it as non-critical and consider RPM transaction successful. Anyway, adjust to not fail the scriptlet and don't worry if the error should be considered fatal or not. QubesOS/qubes-issues#10102
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 3 3
Lines 481 481
=======================================
Hits 342 342
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Application names longer than 37 chars don't fit in qubesdb name limit
for app-dispvm service entry. Switch to using hash of the name, which
has a constant length. Encode SHA256 of the name using URL-safe base64
(instead of hex) to save some length. And since those entries are
generated automatically, move them out of /qubes-service/ qubesdb tree
(into /hash-app-dispvm/), to not interfere with manual entries.
Fixes QubesOS/qubes-issues#7421