-
-
Notifications
You must be signed in to change notification settings - Fork 16
Recent applications and favorites sorting #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
af43ce5
to
79e86b6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 79.53% 80.81% +1.27%
==========================================
Files 23 23
Lines 2561 2768 +207
==========================================
+ Hits 2037 2237 +200
- Misses 524 531 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025100718-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 81 fixed
Unstable testsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:166 tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interaction with recent searched is weird - they cannot be selected by hovering, but when clicked they remain selected even when moving mouse outside of that entry.
Should there be a hint that recent apps can be disabled (similar to the case when it's disabled)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the icons are swapped - this looks more like a Z-A order. And similarly the ones for qube sorting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icons for sorting by qube name look disabled (gray, compared to black for sorting by application)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also a bit weird that sorting by both have application arrow in the same direction, but sorting by qube has in opposite for reversed sorting. But that's a minor thing
Plus add cairo-devel to test dependencies and change line-length for pylint to alighn with black.
caf9c47
to
65f164a
Compare
Both of the points above are still the case for me in this version... |
65f164a
to
9dddd50
Compare
pylint complains:
(it managed to run in this job: https://gitlab.com/QubesOS/qubes-desktop-linux-menu/-/jobs/11599955160) |
9dddd50
to
22f5995
Compare
PipelineRetryFailed |
1 similar comment
PipelineRetryFailed |
fixes QubesOS/qubes-issues#8041