Skip to content

Conversation

marmarta
Copy link
Member

  • blackify menu files
  • implement sorting for favorites
  • implement recently used apps / disabling and enabling this feature in menu settings

fixes QubesOS/qubes-issues#8041

@marmarta marmarta force-pushed the newbranch2207 branch 3 times, most recently from af43ce5 to 79e86b6 Compare July 31, 2025 21:11
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 84.51493% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.81%. Comparing base (a4c3ac3) to head (65f164a).

Files with missing lines Patch % Lines
qubes_menu/favorites_page.py 52.94% 24 Missing ⚠️
qubes_menu/search_page.py 84.55% 19 Missing ⚠️
qubes_menu/appmenu.py 71.42% 18 Missing ⚠️
qubes_menu/custom_widgets.py 82.60% 12 Missing ⚠️
qubes_menu/desktop_file_manager.py 84.21% 3 Missing ⚠️
qubes_menu/app_widgets.py 92.00% 2 Missing ⚠️
qubes_menu/application_page.py 93.93% 2 Missing ⚠️
qubes_menu/vm_manager.py 85.71% 2 Missing ⚠️
qubes_menu/utils.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   79.53%   80.81%   +1.27%     
==========================================
  Files          23       23              
  Lines        2561     2768     +207     
==========================================
+ Hits         2037     2237     +200     
- Misses        524      531       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Aug 3, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025100718-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update

  • system_tests_network_ipv6

  • system_tests_network_updates

    • TC_00_Dom0Upgrade_whonix-gateway-17: test_001_update_check (failure)
      ^... AssertionError: '' is not true

    • TC_10_QvmTemplate_fedora-42-xfce: test_010_template_install (error)
      subprocess.CalledProcessError: Command 'uname -n' returned non-zero...

  • system_tests_audio@hw1

  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/iDVvW-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_dispvm_perf@hw7

    • TC_00_DispVMPerf_whonix-workstation-17: test_406_dom0_dispvm_preload_api (failure)
      AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...

    • TC_00_DispVMPerf_whonix-workstation-17: test_900_reader (failure)
      AssertionError: '/usr/lib/qubes/tests/dispvm_perf_reader.py --templ...

Failed tests

13 failures
  • system_tests_extra

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
  • system_tests_network_ipv6

  • system_tests_network_updates

    • TC_00_Dom0Upgrade_whonix-gateway-17: test_001_update_check (failure)
      ^... AssertionError: '' is not true

    • TC_10_QvmTemplate_fedora-42-xfce: test_010_template_install (error)
      subprocess.CalledProcessError: Command 'uname -n' returned non-zero...

  • system_tests_audio@hw1

  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/iDVvW-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_dispvm_perf@hw7

    • TC_00_DispVMPerf_whonix-workstation-17: test_406_dom0_dispvm_preload_api (failure)
      AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...

    • TC_00_DispVMPerf_whonix-workstation-17: test_900_reader (failure)
      AssertionError: '/usr/lib/qubes/tests/dispvm_perf_reader.py --templ...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/149225#dependencies

81 fixed
  • system_tests_dispvm

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.dispvm failed (exit code 1), details report...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_DispVM_debian-13-xfce: test_012_preload_low_mem (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0

    • TC_20_DispVM_debian-13-xfce: test_013_preload_gui (error)
      raise KeyError(key)... KeyError: 'disp3723'

    • TC_20_DispVM_debian-13-xfce: test_014_preload_nogui (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError

    • TC_20_DispVM_debian-13-xfce: test_015_preload_race_more (error + cleanup)
      raise KeyError(key)... KeyError: 'disp1187'

    • TC_20_DispVM_debian-13-xfce: test_016_preload_race_less (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_20_DispVM_debian-13-xfce: test_017_preload_autostart (error)
      raise KeyError(key)... KeyError: 'disp7317'

    • TC_20_DispVM_debian-13-xfce: test_018_preload_global (error)
      raise KeyError(key)... KeyError: 'disp8572'

    • TC_20_DispVM_debian-13-xfce: test_019_preload_refresh (error)
      raise KeyError(key)... KeyError: 'disp6425'

    • TC_20_DispVM_fedora-42-xfce: test_012_preload_low_mem (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0

    • TC_20_DispVM_whonix-workstation-17: test_012_preload_low_mem (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_audio

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.audio failed (exit code 1), details reporte...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_224_audio_rec_muted_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_audio@hw1

  • system_tests_dispvm_perf@hw7

  • system_tests_guivm_gpu_gui_interactive@hw13

    • guivm_startup: wait_serial (wait serial expected)
      # wait_serial expected: qr/lEcbc-\d+-/...

    • guivm_startup: Failed (test died + timed out)
      # Test died: command '! qvm-check sys-whonix || time qvm-start sys-...

  • system_tests_basic_vm_qrexec_gui_ext4

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.vm_qrexec_gui failed (exit code 1), details...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_NonAudio_whonix-gateway-17-pool: test_012_qubes_desktop_run (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError

Unstable tests

Performance Tests

Performance degradation:

13 performance degradations
  • whonix-workstation-17_exec: 8.50 🔻 ( previous job: 7.57, degradation: 112.24%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 347095.00 🔻 ( previous job: 497426.00, degradation: 69.78%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 229699.00 🔻 ( previous job: 265260.00, degradation: 86.59%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 174180.00 🔻 ( previous job: 431512.00, degradation: 40.37%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 50444.00 🔻 ( previous job: 196254.00, degradation: 25.70%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3203.00 🔻 ( previous job: 3925.00, degradation: 81.61%)
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 27288.00 🔻 ( previous job: 47575.00, degradation: 57.36%)
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 611.00 🔻 ( previous job: 1368.00, degradation: 44.66%)
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 82166.00 🔻 ( previous job: 136640.00, degradation: 60.13%)
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 96969.00 🔻 ( previous job: 157382.00, degradation: 61.61%)
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 32751.00 🔻 ( previous job: 64217.00, degradation: 51.00%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2142.00 🔻 ( previous job: 4098.00, degradation: 52.27%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1469.00 🔻 ( previous job: 2384.00, degradation: 61.62%)

Remaining performance tests:

166 tests
  • debian-13-xfce_exec: 5.15 🟢 ( previous job: 8.36, improvement: 61.61%)
  • debian-13-xfce_exec-root: 27.05 🟢 ( previous job: 27.36, improvement: 98.87%)
  • debian-13-xfce_socket: 7.73 🟢 ( previous job: 8.57, improvement: 90.18%)
  • debian-13-xfce_socket-root: 8.30 🔻 ( previous job: 8.26, degradation: 100.54%)
  • debian-13-xfce_exec-data-simplex: 68.76 🟢 ( previous job: 72.43, improvement: 94.93%)
  • debian-13-xfce_exec-data-duplex: 70.52 🟢 ( previous job: 76.65, improvement: 92.01%)
  • debian-13-xfce_exec-data-duplex-root: 83.73 🟢 ( previous job: 91.79, improvement: 91.22%)
  • debian-13-xfce_socket-data-duplex: 130.40 🟢 ( previous job: 133.45, improvement: 97.71%)
  • fedora-42-xfce_exec: 9.15 🔻 ( previous job: 9.06, degradation: 101.00%)
  • fedora-42-xfce_exec-root: 58.74 🔻 ( previous job: 58.19, degradation: 100.94%)
  • fedora-42-xfce_socket: 8.44 🟢 ( previous job: 8.48, improvement: 99.58%)
  • fedora-42-xfce_socket-root: 8.00 🟢 ( previous job: 8.18, improvement: 97.77%)
  • fedora-42-xfce_exec-data-simplex: 67.14 🟢 ( previous job: 78.48, improvement: 85.54%)
  • fedora-42-xfce_exec-data-duplex: 69.10 🔻 ( previous job: 67.92, degradation: 101.74%)
  • fedora-42-xfce_exec-data-duplex-root: 100.67 🔻 ( previous job: 96.36, degradation: 104.48%)
  • fedora-42-xfce_socket-data-duplex: 139.52 🟢 ( previous job: 142.58, improvement: 97.85%)
  • whonix-gateway-17_exec: 7.11 🟢 ( previous job: 8.12, improvement: 87.56%)
  • whonix-gateway-17_exec-root: 38.71 🟢 ( previous job: 41.05, improvement: 94.30%)
  • whonix-gateway-17_socket: 7.70 🟢 ( previous job: 8.52, improvement: 90.28%)
  • whonix-gateway-17_socket-root: 7.88 🟢 ( previous job: 8.12, improvement: 97.01%)
  • whonix-gateway-17_exec-data-simplex: 65.61 🟢 ( previous job: 83.60, improvement: 78.49%)
  • whonix-gateway-17_exec-data-duplex: 69.08 🔻 ( previous job: 68.38, degradation: 101.02%)
  • whonix-gateway-17_exec-data-duplex-root: 86.06 🟢 ( previous job: 99.37, improvement: 86.61%)
  • whonix-gateway-17_socket-data-duplex: 152.50 🟢 ( previous job: 167.12, improvement: 91.26%)
  • whonix-workstation-17_exec-root: 54.32 🟢 ( previous job: 56.76, improvement: 95.71%)
  • whonix-workstation-17_socket: 8.08 🟢 ( previous job: 8.59, improvement: 94.09%)
  • whonix-workstation-17_socket-root: 8.78 🟢 ( previous job: 8.89, improvement: 98.81%)
  • whonix-workstation-17_exec-data-simplex: 67.29 🔻 ( previous job: 66.80, degradation: 100.73%)
  • whonix-workstation-17_exec-data-duplex: 71.72 🟢 ( previous job: 74.50, improvement: 96.27%)
  • whonix-workstation-17_exec-data-duplex-root: 88.44 🟢 ( previous job: 102.34, improvement: 86.42%)
  • whonix-workstation-17_socket-data-duplex: 147.17 🟢 ( previous job: 147.97, improvement: 99.45%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 54272.00 🟢 ( previous job: 23940.00, improvement: 226.70%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5109.00 🟢 ( previous job: 2446.00, improvement: 208.87%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 10042.00 🟢 ( previous job: 5874.00, improvement: 170.96%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4744.00 🟢 ( previous job: 29.00, improvement: 16358.62%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 433116.00 🟢 ( previous job: 292489.00, improvement: 148.08%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 242669.00 🟢 ( previous job: 110817.00, improvement: 218.98%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 435274.00 🟢 ( previous job: 137802.00, improvement: 315.87%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 180237.00 🟢 ( previous job: 121719.00, improvement: 148.08%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 105193.00 🟢 ( previous job: 103932.00, improvement: 101.21%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 8527.00 🟢 ( previous job: 6356.00, improvement: 134.16%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8139.00 🟢 ( previous job: 7695.00, improvement: 105.77%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 347555.00 🔻 ( previous job: 366891.00, degradation: 94.73%)
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 164368.00 🟢 ( previous job: 140215.00, improvement: 117.23%)
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 293143.00 🔻 ( previous job: 299764.00, degradation: 97.79%)
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 83340.00 🔻 ( previous job: 86001.00, degradation: 96.91%)
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3017.00 🔻 ( previous job: 3020.00, degradation: 99.90%)
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8344.00 🔻 ( previous job: 9042.00, degradation: 92.28%)
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 389226.00 🟢 ( previous job: 387500.00, improvement: 100.45%)
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 367534.00 🟢 ( previous job: 325139.00, improvement: 113.04%)
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 79712.00 🟢 ( previous job: 79539.00, improvement: 100.22%)
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 85156.00 🔻 ( previous job: 87396.00, degradation: 97.44%)
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3498.00 🔻 ( previous job: 3765.00, degradation: 92.91%)
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8635.00 🔻 ( previous job: 8992.00, degradation: 96.03%)
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1416.00 🟢 ( previous job: 1251.00, improvement: 113.19%)
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 368179.00 🔻 ( previous job: 383531.00, degradation: 96.00%)
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 291838.00 🔻 ( previous job: 293225.00, degradation: 99.53%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 81081.00 🔻 ( previous job: 87141.00, degradation: 93.05%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8495.00 🔻 ( previous job: 8804.00, degradation: 96.49%)
  • debian-13-xfce_vm-dispvm (mean:6.707): 80.48
  • debian-13-xfce_vm-dispvm-gui (mean:7.905): 94.86
  • debian-13-xfce_vm-dispvm-concurrent (mean:3.524): 42.28
  • debian-13-xfce_vm-dispvm-gui-concurrent (mean:4.212): 50.55
  • debian-13-xfce_dom0-dispvm (mean:6.96): 83.53
  • debian-13-xfce_dom0-dispvm-gui (mean:8.279): 99.34
  • debian-13-xfce_dom0-dispvm-concurrent (mean:3.427): 41.12
  • debian-13-xfce_dom0-dispvm-gui-concurrent (mean:4.058): 48.70
  • debian-13-xfce_vm-dispvm-preload (mean:3.01): 36.12
  • debian-13-xfce_vm-dispvm-preload-gui (mean:4.052): 48.62
  • debian-13-xfce_vm-dispvm-preload-concurrent (mean:2.705): 32.46
  • debian-13-xfce_vm-dispvm-preload-gui-concurrent (mean:3.324): 39.89
  • debian-13-xfce_dom0-dispvm-preload (mean:3.421): 41.06
  • debian-13-xfce_dom0-dispvm-preload-gui (mean:10.599): 127.19
  • debian-13-xfce_dom0-dispvm-preload-concurrent (mean:3.089): 37.07
  • debian-13-xfce_dom0-dispvm-preload-gui-concurrent (mean:3.835): 46.02
  • debian-13-xfce_dom0-dispvm-api (mean:6.87): 82.44
  • debian-13-xfce_dom0-dispvm-gui-api (mean:8.254): 99.04
  • debian-13-xfce_dom0-dispvm-concurrent-api (mean:3.269): 39.23
  • debian-13-xfce_dom0-dispvm-gui-concurrent-api (mean:3.995): 47.94
  • debian-13-xfce_dom0-dispvm-preload-less-less-api (mean:3.695): 44.34
  • debian-13-xfce_dom0-dispvm-preload-less-api (mean:3.479): 41.75
  • debian-13-xfce_dom0-dispvm-preload-api (mean:3.487): 41.85
  • debian-13-xfce_dom0-dispvm-preload-more-api (mean:3.447): 41.36
  • debian-13-xfce_dom0-dispvm-preload-more-more-api (mean:3.473): 41.67
  • debian-13-xfce_dom0-dispvm-preload-gui-api (mean:4.475): 53.70
  • debian-13-xfce_dom0-dispvm-preload-concurrent-api (mean:2.97): 35.65
  • debian-13-xfce_dom0-dispvm-preload-gui-concurrent-api (mean:3.69): 44.27
  • debian-13-xfce_vm-vm (mean:0.026): 0.32
  • debian-13-xfce_vm-vm-gui (mean:0.035): 0.42
  • debian-13-xfce_vm-vm-concurrent (mean:0.014): 0.16
  • debian-13-xfce_vm-vm-gui-concurrent (mean:0.022): 0.27
  • debian-13-xfce_dom0-vm-api (mean:0.038): 0.45
  • debian-13-xfce_dom0-vm-gui-api (mean:0.039): 0.47
  • debian-13-xfce_dom0-vm-concurrent-api (mean:0.025): 0.30
  • debian-13-xfce_dom0-vm-gui-concurrent-api (mean:0.029): 0.35
  • fedora-42-xfce_vm-dispvm (mean:7.05): 84.60
  • fedora-42-xfce_vm-dispvm-gui (mean:8.419): 101.03
  • fedora-42-xfce_vm-dispvm-concurrent (mean:4.107): 49.29
  • fedora-42-xfce_vm-dispvm-gui-concurrent (mean:4.43): 53.16
  • fedora-42-xfce_dom0-dispvm (mean:7.637): 91.64
  • fedora-42-xfce_dom0-dispvm-gui (mean:8.995): 107.95
  • fedora-42-xfce_dom0-dispvm-concurrent (mean:3.978): 47.73
  • fedora-42-xfce_dom0-dispvm-gui-concurrent (mean:4.722): 56.66
  • fedora-42-xfce_vm-dispvm-preload (mean:3.004): 36.05
  • fedora-42-xfce_vm-dispvm-preload-gui (mean:7.031): 84.37
  • fedora-42-xfce_vm-dispvm-preload-concurrent (mean:2.942): 35.31
  • fedora-42-xfce_vm-dispvm-preload-gui-concurrent (mean:3.948): 47.38
  • fedora-42-xfce_dom0-dispvm-preload (mean:4.074): 48.89
  • fedora-42-xfce_dom0-dispvm-preload-gui (mean:5.012): 60.15
  • fedora-42-xfce_dom0-dispvm-preload-concurrent (mean:3.211): 38.53
  • fedora-42-xfce_dom0-dispvm-preload-gui-concurrent (mean:4.193): 50.32
  • fedora-42-xfce_dom0-dispvm-api (mean:7.603): 91.23
  • fedora-42-xfce_dom0-dispvm-gui-api (mean:8.727): 104.72
  • fedora-42-xfce_dom0-dispvm-concurrent-api (mean:3.904): 46.85
  • fedora-42-xfce_dom0-dispvm-gui-concurrent-api (mean:4.471): 53.65
  • fedora-42-xfce_dom0-dispvm-preload-less-less-api (mean:4.287): 51.44
  • fedora-42-xfce_dom0-dispvm-preload-less-api (mean:4.027): 48.33
  • fedora-42-xfce_dom0-dispvm-preload-api (mean:3.844): 46.13
  • fedora-42-xfce_dom0-dispvm-preload-more-api (mean:3.716): 44.59
  • fedora-42-xfce_dom0-dispvm-preload-more-more-api (mean:3.79): 45.48
  • fedora-42-xfce_dom0-dispvm-preload-gui-api (mean:5.061): 60.73
  • fedora-42-xfce_dom0-dispvm-preload-concurrent-api (mean:3.545): 42.54
  • fedora-42-xfce_dom0-dispvm-preload-gui-concurrent-api (mean:4.309): 51.71
  • fedora-42-xfce_vm-vm (mean:0.029): 0.35
  • fedora-42-xfce_vm-vm-gui (mean:0.044): 0.53
  • fedora-42-xfce_vm-vm-concurrent (mean:0.027): 0.33
  • fedora-42-xfce_vm-vm-gui-concurrent (mean:0.033): 0.40
  • fedora-42-xfce_dom0-vm-api (mean:0.04): 0.48
  • fedora-42-xfce_dom0-vm-gui-api (mean:0.047): 0.57
  • fedora-42-xfce_dom0-vm-concurrent-api (mean:0.034): 0.41
  • fedora-42-xfce_dom0-vm-gui-concurrent-api (mean:0.034): 0.40
  • whonix-workstation-17_vm-dispvm (mean:7.603): 91.23
  • whonix-workstation-17_vm-dispvm-gui (mean:8.488): 101.86
  • whonix-workstation-17_vm-dispvm-concurrent (mean:4.158): 49.90
  • whonix-workstation-17_vm-dispvm-gui-concurrent (mean:4.518): 54.21
  • whonix-workstation-17_dom0-dispvm (mean:8.414): 100.97
  • whonix-workstation-17_dom0-dispvm-gui (mean:9.231): 110.77
  • whonix-workstation-17_dom0-dispvm-concurrent (mean:4.441): 53.29
  • whonix-workstation-17_dom0-dispvm-gui-concurrent (mean:4.783): 57.39
  • whonix-workstation-17_vm-dispvm-preload (mean:3.337): 40.04
  • whonix-workstation-17_vm-dispvm-preload-gui (mean:4.621): 55.45
  • whonix-workstation-17_vm-dispvm-preload-concurrent (mean:3.228): 38.73
  • whonix-workstation-17_vm-dispvm-preload-gui-concurrent (mean:4.055): 48.67
  • whonix-workstation-17_dom0-dispvm-preload (mean:4.718): 56.62
  • whonix-workstation-17_dom0-dispvm-preload-gui (mean:5.438): 65.25
  • whonix-workstation-17_dom0-dispvm-preload-concurrent (mean:3.823): 45.88
  • whonix-workstation-17_dom0-dispvm-preload-gui-concurrent (mean:4.397): 52.76
  • whonix-workstation-17_dom0-dispvm-api (mean:8.294): 99.53
  • whonix-workstation-17_dom0-dispvm-gui-api (mean:9.149): 109.79
  • whonix-workstation-17_dom0-dispvm-concurrent-api (mean:4.066): 48.79
  • whonix-workstation-17_dom0-dispvm-gui-concurrent-api (mean:4.596): 55.15
  • whonix-workstation-17_dom0-dispvm-preload-less-less-api (mean:4.669): 56.02
  • whonix-workstation-17_dom0-dispvm-preload-less-api (mean:4.922): 59.06
  • whonix-workstation-17_dom0-dispvm-preload-more-api (mean:4.32): 51.84
  • whonix-workstation-17_dom0-dispvm-preload-more-more-api (mean:4.528): 54.33
  • whonix-workstation-17_dom0-dispvm-preload-gui-api (mean:5.531): 66.37
  • whonix-workstation-17_dom0-dispvm-preload-concurrent-api (mean:3.845): 46.14
  • whonix-workstation-17_dom0-dispvm-preload-gui-concurrent-api (mean:4.694): 56.33
  • whonix-workstation-17_vm-vm (mean:0.029): 0.35
  • whonix-workstation-17_vm-vm-gui (mean:0.036): 0.43
  • whonix-workstation-17_vm-vm-concurrent (mean:0.022): 0.27
  • whonix-workstation-17_vm-vm-gui-concurrent (mean:0.028): 0.33
  • whonix-workstation-17_dom0-vm-api (mean:0.043): 0.51
  • whonix-workstation-17_dom0-vm-gui-api (mean:0.056): 0.67
  • whonix-workstation-17_dom0-vm-concurrent-api (mean:0.032): 0.38
  • whonix-workstation-17_dom0-vm-gui-concurrent-api (mean:0.03): 0.36

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interaction with recent searched is weird - they cannot be selected by hovering, but when clicked they remain selected even when moving mouse outside of that entry.

Should there be a hint that recent apps can be disabled (similar to the case when it's disabled)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the icons are swapped - this looks more like a Z-A order. And similarly the ones for qube sorting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons for sorting by qube name look disabled (gray, compared to black for sorting by application)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also a bit weird that sorting by both have application arrow in the same direction, but sorting by qube has in opposite for reversed sorting. But that's a minor thing

Plus add cairo-devel to test dependencies and
change line-length for pylint to alighn with black.
@marmarek
Copy link
Member

Interaction with recent searched is weird - they cannot be selected by hovering, but when clicked they remain selected even when moving mouse outside of that entry.

Should there be a hint that recent apps can be disabled (similar to the case when it's disabled)?

Both of the points above are still the case for me in this version...

@marmarek
Copy link
Member

marmarek commented Oct 4, 2025

pylint complains:

************* Module qubes_menu.search_page
qubes_menu/search_page.py:322:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
qubes_menu/search_page.py:25:0: W0611: Unused HoverListBox imported from custom_widgets (unused-import)

(it managed to run in this job: https://gitlab.com/QubesOS/qubes-desktop-linux-menu/-/jobs/11599955160)

@marmarta
Copy link
Member Author

marmarta commented Oct 6, 2025

PipelineRetryFailed

1 similar comment
@marmarta
Copy link
Member Author

marmarta commented Oct 6, 2025

PipelineRetryFailed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore and implement sorting/search? in menu favorites
3 participants