Fix multiple issues with preload tests #715
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
==========================================
- Coverage 70.56% 70.50% -0.06%
==========================================
Files 61 61
Lines 13604 13604
==========================================
- Hits 9599 9591 -8
- Misses 4005 4013 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A full run with Debian
|
|
If these changes are not enough, I will make logging similar to the disposable integration test, in other words, a lot of logging. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025082411-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 72 fixed
Unstable testsPerformance TestsPerformance degradation:19 performance degradations
Remaining performance tests:155 tests
|
ben-grande
force-pushed
the
preload-perf-fix
branch
from
52ad91f to
ef42f07
Compare
ben-grande
force-pushed
the
preload-perf-fix
branch
from
ef42f07 to
c46d62d
Compare
|
|
|
The other |
If the system is still starting, slow services may delay the shutdown beyond the default timeout, making the test fail. For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-perf-fix
branch
from
c46d62d to
1201890
Compare
|
Refresh issue of hanging because of dovecot possibly fixed on 1201890 The other issues appear to be because of the threshold set by the installer. |
ben-grande
force-pushed
the
preload-perf-fix
branch
from
4e322e7 to
e7e3146
Compare
ben-grande
changed the title
ben-grande
force-pushed
the
preload-perf-fix
branch
from
e7e3146 to
0d587ad
Compare
|
OpenQA seems happy: |
tests/dispvm_perf.py
Outdated
| if orig_preload_max != 0 and self.app.default_dispvm: | ||
| asyncio.run( | ||
| self.wait_preload( | ||
| orig_preload_max, appvm=self.app.default_dispvm | ||
| ) | ||
| ) |
There was a problem hiding this comment.
You remove this part few commits later anyway, so 0618ff6 is not needed, no?
There was a problem hiding this comment.
Yes, rebased and removed unecessary commits.
tests/dispvm_perf.py
Outdated
| f'max_concurrency="{MAX_CONCURRENCY}"; ' | ||
| f"for i in $(seq {self.iterations}); do " | ||
| f" out=$({cmd}) {term}" | ||
| ' echo "$i"' |
There was a problem hiding this comment.
Yes, added to the same commit now.
Because it is set by the installer and may also be set by the user, it is important to not let the tests be affected by the global preload. Setting the global preload again will not preload, as qubesd is not running. For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-perf-fix
branch
from
e7e6deb to
320a68a
Compare
ben-grande
force-pushed
the
preload-perf-fix
branch
2 times, most recently
from
9674971 to
1938e06
Compare
ben-grande
force-pushed
the
preload-perf-fix
branch
from
1938e06 to
d280511
Compare
For: QubesOS/qubes-issues#1512
For: #708
tearDown()anymorefinallyclause, we already have the test configuration so it is easier to consider different factors for different delays, customizing to sleep less when possible and more when neededCurrently running with 16GB of RAM the full test suite for Debian.