Add Virtual DNS for IPv6 (#558) #695
Conversation
- Add IPv6 DNS if netvm has ipv6 feature enabled. For this there is a need to only add Virtual DNS servers to qubes that have netvm set and don't add DNS to every qube that provides network (sys-net/sys-usb/etc). - Add IPv6 Virtual DNS support. Also some IPv6 fixes and tests. - Remove feature supported-feature.ipv6 and add feature supported-feature.ipv6dns
|
Haven't figured out how to reproduce the failing python black linting locally: https://gitlab.com/QubesOS/qubes-core-admin/-/jobs/10583251890#L291 (With the same version of black it reformats way more than that, including unchanged lines and files) |
|
I've added issue reference to PR descriptions, please include it also in a commit message next time you push a change (in both PRs). |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025090403-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests36 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 73 fixed
Unstable testsPerformance TestsPerformance degradation:15 performance degradations
Remaining performance tests:57 tests
|
* add-ipv6-dns: Add Virtual DNS for IPv6 Part of QubesOS/qubes-issues#10038
3nprob
force-pushed
the
add-ipv6-dns-rebased
branch
from
ddcab75 to
4135aed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
==========================================
+ Coverage 70.83% 70.85% +0.01%
==========================================
Files 61 61
Lines 13463 13474 +11
==========================================
+ Hits 9537 9547 +10
- Misses 3926 3927 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| self.vm.features["ipv6"] = "1" | ||
| value = self.call_mgmt_func( | ||
| b"admin.vm.property.Get", b"test-vm1", b"dns" | ||
| b"admin.vm.property.Get", b"test-vm1", b"dns6" | ||
| ) | ||
| self.assertEqual(value, "default=True type=str ") | ||
| self.vm.features["supported-feature.ipv6dns"] = "1" | ||
| value = self.call_mgmt_func( | ||
| b"admin.vm.property.Get", b"test-vm1", b"dns6" |
There was a problem hiding this comment.
This discards the IPv4 DNS test. I'm not sure that's intentional or desirable.
No changes beyond conflict resolution and formatting lint
Related
Fixes QubesOS/qubes-issues#10038